Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #232: [FR] support l template #233

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

lasconic
Copy link
Collaborator

  • Fixes [FR] support l template #232
  • Tests added/updated.
  • ./check.sh run and eventual issues fixed.
  • Updated CONTRIBUTORS.md, if not already done in the past.

@BoboTiG BoboTiG merged commit 38eabf1 into BoboTiG:master Nov 20, 2020
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 20, 2020

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 111.80 ⛔ 112.67 ⛔ 0.87 👎
Method Length 551.67 ⛔ 553.00 ⛔ 1.33 👎
Working memory 67.08 ⛔ 67.08 ⛔ 0.00
Quality 7.26% 7.26% 0.00%
Other metrics Before After Change
Lines 890 892 2
Changed files Quality Before Quality After Quality Change
scripts/lang/fr/init.py 7.26% ⛔ 7.26% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
scripts/lang/fr/init.py last_template_handler 130 ⛔ 827 ⛔ 25 ⛔ 1.96% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] support l template
2 participants