Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support 'note-fr-féminin-homme' and 'note-fr-masculin-femme' tem… #371

Merged
merged 1 commit into from Nov 25, 2020

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Nov 25, 2020

…plates (closes #361)

Ex: https://fr.wiktionary.org/wiki/altesse

@BoboTiG
Copy link
Owner Author

BoboTiG commented Nov 25, 2020

@lasconic WDYT about the warning sign? It is used on the Wikipage but i am not sure we should keep it or not.

Repository owner deleted a comment from sourcery-ai bot Nov 25, 2020
@lasconic
Copy link
Collaborator

I would remove it

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 25, 2020

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 196.33 ⛔ 196.33 ⛔ 0.00
Method Length 804.33 ⛔ 805.67 ⛔ 1.34 👎
Working memory 52.46 ⛔ 52.46 ⛔ 0.00
Quality 4.23% 4.23% 0.00%
Other metrics Before After Change
Lines 1196 1198 2
Changed files Quality Before Quality After Quality Change
scripts/lang/fr/init.py 4.23% ⛔ 4.23% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
scripts/lang/fr/init.py last_template_handler 212 ⛔ 1509 ⛔ 28 ⛔ 1.20% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit c87fb56 into master Nov 25, 2020
@BoboTiG BoboTiG deleted the fix-361 branch November 25, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Support 'note-fr-féminin-homme'
2 participants