Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move disqus_shortname fallback logic into accessor block #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

natchiketa
Copy link

I was having an issue where I couldn't use the disqus_shortname attribute I set in config/initializers/blogit.rb this seemed to be because of the setter in lib/blogit/configuration.rb, which seems to be concerned with the fallback and firing the warning if it's set without include_comments being set to :disqus.

That method sets an instance variable in Blogit::Configuration though, which didn't work with the default comments view. By moving that logic from the setter into the accessor block, all I had to do was set my :disqus_shortname in the initializer and everything works automagically!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant