Rails 5.1 #93
Open
Rails 5.1 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by conditionally installing development gems
ruby 2.2+. LoadError: Ruby 2.2+ has removed test/unit from the core library. Rails requires this as a dependency. Please add test-unit gem to your Gemfile: `gem 'test-unit', '~> 3.0'` (cannot load such file -- test/unit)"
https://docs.codeclimate.com/v1.0/docs/travis-ci-ruby-test-coverage removed from spec helper since it complained as follows: This usage of the Code Climate Test Reporter is now deprecated. Since version 1.0, we now require you to run `SimpleCov` in your test/spec helper, and then run the provided `codeclimate-test-reporter` binary separately to report your results to Code Climate.
AS::Configurable's `config_accessor` supports a default block only since rails 4 -- see rails/rails#7645.
resolves the following error: $ rake acts_as_taggable_on_engine:install:migrations rake aborted! NoMethodError: undefined method `last_comment' for #<Rake::Application:0x0055d4f8455538>
based on the activerecord version being used
stubbed nil arguments will end up as "" in the controller's params hash.
some weird things with the rakefiles going on.
related travis log: $ bundle exec rake db:migrate RAILS_ENV=test /home/travis/build/KatanaCode/blogit/lib/tasks/blogit/doc.rake:9: warning: already initialized constant DOC_FILES /home/travis/build/KatanaCode/blogit/lib/tasks/blogit/doc.rake:9: warning: previous definition of DOC_FILES was here rake aborted! StandardError: An error has occurred, this and all later migrations canceled: Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for: class CreateUsers < ActiveRecord::Migration[4.2] /home/travis/.rvm/gems/ruby-2.4.0/gems/activerecord-5.1.0.beta1/lib/active_record/migration.rb:525:in `inherited' /home/travis/build/KatanaCode/blogit/spec/dummy/db/migrate/20110814091304_create_users.rb:1:in `<top (required)>'
|
alright. 4.2 and 5.1 tests are green. supporting earlier versions is pointless pain, in my opinion, as they're all eol. @Bodacious, still there? |
|
@glaszig Thanks for doing this. I'll get back to you ASAP with these PRs. |
|
hello? |
|
This gem being actively maintained anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds tests for rails 5.1.
unfortunately, controller testing changed quite heavily (they're integration tests by default) so those won't run on anything < 5 anymore. not sure how you'd like to approach this.
also makes some other adjustments for which i was too impatient to create separate PRs:
gemfiles/*.lock