small refactoring of findOne func #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SkobelkinYaroslav
commented
Mar 24, 2024
SkobelkinYaroslav
commented
- combined two if statements into one: made quick research, since we use filepath.WalkDir, there is no need in returning fs.SkipDir value
- removed strings.TrimPrefix. Under the hood it makes additional check, if string has pefix. Since we sure, that we always get file extension with dot, we don't need this check
…elds because of optimization (arrays were used only to check the occurrence of an element)
kehoecj
added
the
OSS Community Contribution
kehoecj
added
the
waiting-on-maintainer-review
kehoecj
removed
the
waiting-on-maintainer-review
kehoecj
approved these changes
Mar 29, 2024
|
Thank you @SkobelkinYaroslav for another great PR! |
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* changed []string to map[string]struct{} in FileSystemFinder struct fields because of optimization (arrays were used only to check the occurrence of an element)
* Changed field Extensions type in FileType from []string to map[string]struct{}
* added requested changes
* small refactoring of findOne func
* fixd the return value
* get back to trimprefix func
* cleanup
---------
Co-authored-by: Yaroslav <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.