Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass max_age from init #240

Closed
wants to merge 4 commits into from
Closed

pass max_age from init #240

wants to merge 4 commits into from

Conversation

@evstratbg
Copy link
Contributor

evstratbg commented Dec 3, 2019

No description provided.

Copy link

codingjoe left a comment

Good catch, we should probably also have that covered somewhere in a simple test.

.gitignore Outdated
@@ -9,3 +9,4 @@
/*.egg-info
/htmlcov
__pycache__
.idea

This comment has been minimized.

Copy link
@codingjoe

codingjoe Dec 8, 2019

Unrelated change. Please make sure exclude your pyCharm related files via a global .gitignor.

Suggested change
.idea

This comment has been minimized.

Copy link
@evstratbg

evstratbg Dec 8, 2019

Author Contributor

ok, thank you

There is a flake8 addon, called flake8-unused-arguments. The name speaks for itself

This comment has been minimized.

Copy link
@codingjoe

codingjoe Dec 12, 2019

Trailing newline is missing. I'd suggest reviewing your own changeset once, to make sure nothing commit that you didn't intend to change.

@Bogdanp

This comment has been minimized.

Copy link
Owner

Bogdanp commented Dec 9, 2019

Thanks! @evstratbg please add yourself to the CONTRIBUTORS.md file. I'll take over and merge this afterwards.

evstratbg added 3 commits Dec 9, 2019
Copy link

codingjoe left a comment

LGTM 🎉

@Bogdanp

This comment has been minimized.

Copy link
Owner

Bogdanp commented Dec 13, 2019

Thanks! This is now merged w/ rebase.

@Bogdanp Bogdanp closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.