-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass max_age from init #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, we should probably also have that covered somewhere in a simple test.
.gitignore
Outdated
@@ -9,3 +9,4 @@ | |||
/*.egg-info | |||
/htmlcov | |||
__pycache__ | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change. Please make sure exclude your pyCharm related files via a global .gitignor.
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thank you
There is a flake8 addon, called flake8-unused-arguments. The name speaks for itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing newline is missing. I'd suggest reviewing your own changeset once, to make sure nothing commit that you didn't intend to change.
Thanks! @evstratbg please add yourself to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thanks! This is now merged w/ rebase. |
No description provided.