Repository navigation
Conversation
ethervoid
marked this pull request as ready for review
October 12, 2021 14:46
Delayed queue is not tuneable so you could end up fetching the almost the limit of the LUA stack size and have a server crash in redis because when redis cannot perform lua_checkstack it ends with a serverPanic as you can see [h Signed-off-by: Mario de Frutos <mario@defrutos.org>
We want to be able to define an static value for our LUA stack so we don't need to rely on dynamic calculations although if we don't pass that new env. variable we're going to check the max stack value dynamically Signed-off-by: Mario de Frutos <mario@defrutos.org>
There are some possible stack overflow problems if we have a high number of workers and all of the unpack with the maximum limit of the stack. This change reduces to half that value so we don't incur in the stack overflow. See Bogdanp#433 Signed-off-by: Mario de Frutos <mario@defrutos.org>
Signed-off-by: Mario de Frutos <mario@defrutos.org>
ethervoid
force-pushed
the
variable_delayed_queue_prefetch
branch
from
October 12, 2021 14:50
4a5ccea to
8d3050d
Compare
Contributor
Author
|
@Bogdanp I've tried to run I've been getting this error in Mac and Ubuntu inside docker: and looks like tox is not installing the necessary dependencies. Anything I'm missing? |
Owner
|
Thanks! I've merged the change with rebase. Re. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've found that with a great number of delayed messages, using the max LUA stack in the prefetch for delayed messages and multiple workers you can end up having stack overflow in Redis and crashing the LUA script so this PR intends to minimize that situation:
Related to #433