Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageGalleryHeader.tsx not to lode photo.user.name if name does not exist in the response #1

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

Bogdastotel
Copy link
Owner

@Bogdastotel Bogdastotel commented Jul 2, 2023

Updated image gallery header component username to use photo?.user?.id instead of photo?.user?.name (because "name" is currently undefined) leading to header username being 'Unknown user'. With the user.id it loads the username of the photo uploader correctly

🎯 Goal

Updated image gallery header component username to use photo?.user?.id instead of photo?.user?.name (because "name" is currently undefined)

🛠 Implementation details

just added {photo?.user?.name || photo?.user?.id || t('Unknown User')} to load user.id instead of user.name if name does not exist in the photo response

changed image gallery header component

🎨 UI Changes

Simulator Screen Shot - iPhone 14 Pro - 2023-07-01 at 21 14 55

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

Updated  image gallery header component username to use photo?.user?.id instead of photo?.user?.name (because "name" is currently undefined)
@Bogdastotel Bogdastotel merged commit b90a250 into develop Jul 2, 2023
@Bogdastotel Bogdastotel changed the title Update ImageGalleryHeader.tsx Update ImageGalleryHeader.tsx not to lode photo.user.name if name does not exist in the response Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant