Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ecdh and recovery module #3

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

ph4r05
Copy link
Contributor

@ph4r05 ph4r05 commented Jul 22, 2019

No description provided.

@koraykoska
Copy link
Member

Explain please

@ph4r05
Copy link
Contributor Author

ph4r05 commented Jul 22, 2019

ECDH module is not included, i.e., ENABLE_MODULE_ECDH is not defined, thus ECDH functionality defined in https://github.com/Boilertalk/secp256k1/blob/d5407179912e8c1f825a212a474aaa86b10f1352/include/secp256k1_ecdh.h#L20 is not compiled in. Linking fails.
https://github.com/Boilertalk/secp256k1/blob/d5407179912e8c1f825a212a474aaa86b10f1352/src/secp256k1.c#L591

@ph4r05
Copy link
Contributor Author

ph4r05 commented Dec 6, 2019

ping

@koraykoska
Copy link
Member

Make sure Travis completes successfully.

@ph4r05
Copy link
Contributor Author

ph4r05 commented Feb 27, 2020

OK I will check that out

@tureck1y
Copy link

Please, merge this PR. We are losing important functionality

@ph4r05
Copy link
Contributor Author

ph4r05 commented May 25, 2020

Ah I forgot about the Travis. I will check that out

@tureck1y
Copy link

This problem may be related to #10

@ph4r05
Copy link
Contributor Author

ph4r05 commented May 25, 2020

The build problem is still present. I have no idea why

@simonmcl
Copy link
Contributor

simonmcl commented Oct 7, 2021

These missing modules are now causing permanent warnings in Xcode 13: #13 . Looks like this and other PRs are blocked because of the test target failing to launch in Travis. Has anyone made any progress with this?

@simonmcl
Copy link
Contributor

simonmcl commented Oct 7, 2021

I've fixed the travis issues here: #14 tagged the owner to try get it merged, to unblock this PR

@simonmcl
Copy link
Contributor

simonmcl commented Feb 7, 2022

@ph4r05 The PR containing a fix for the Travis CI build issue has been merged in. Can you rebase this PR on the latest code to avoid this failure. Really keen to get this merged in and tagged

@ph4r05 ph4r05 force-pushed the pr/ecdh branch 2 times, most recently from 1ed40da to 217e362 Compare February 7, 2022 12:41
@ph4r05
Copy link
Contributor Author

ph4r05 commented Feb 7, 2022

@simonmcl rebased

@simonmcl
Copy link
Contributor

simonmcl commented Feb 7, 2022

@ph4r05 thanks!

@koraykoska can we get this one merged in and then tag a new version, hopefully this gets rid of the Xcode warnings

@koraykoska koraykoska merged commit b00bbdc into Boilertalk:master Feb 8, 2022
@koraykoska
Copy link
Member

@ph4r05 @simonmcl Done. Thanks for your contributions.

@koraykoska
Copy link
Member

@ph4r05 @simonmcl Tagged as well. https://github.com/Boilertalk/secp256k1.swift/releases/tag/0.1.5

@simonmcl
Copy link
Contributor

simonmcl commented Feb 9, 2022

@ph4r05 i'm getting this error when trying to use 0.1.5 as part of a swift package. Can you have a look and see what the issue might be?

Screenshot 2022-02-09 at 09 36 52

@simonmcl
Copy link
Contributor

simonmcl commented Feb 9, 2022

@ph4r05 never mind, looks like it was fixed here: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants