Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alignment controls for post list 'entry-footer' links #11

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

jamesros161
Copy link
Collaborator

@jamesros161 jamesros161 commented Jan 18, 2023

Resolves #10

crio-2.19.0-issue-10.zip

  1. Install Crio and activate starter content ( or install an inspiration with a blog, then replace with this zip ).
  2. Add a comment to at least one post shown on the blog page
  3. Add at least one tag to the post.
  4. Add at least one category to the post.
  5. Open the customizer and navigate to Design > Blog > Blog Page > Links
  6. Open the Tag Links section.
  7. If the display option is set to none, change to show. Ensure the Alignment control displays, and that you can change left, center, and right alignment.
  8. Publish, and ensure the blog displays properly outside the customizer.
  9. Repeat Steps 6 - 8 for the Category Links and the Comment Links

@jamesros161 jamesros161 changed the title Issue 10 Add alignment controls for post list 'entry-footer' links Jan 19, 2023
@nicolepaschen
Copy link
Member

The alignment for category and tags looks good.

For comments, this made me realize the icon for comments is missing, and has been for awhile. I found them active in version 2.2.14:
crio2-2-14

This is what the Customizer looks like now:
current-customizer

The code is trying to pull a font awesome icon but can't and that adds extra space that makes comments not line up when everything is centered.
current-code

@jamesros161 jamesros161 merged commit 1789747 into branch-2.19.0 Feb 6, 2023
@jamesros161 jamesros161 deleted the issue-10 branch February 6, 2023 21:14
@jamesros161 jamesros161 mentioned this pull request Feb 6, 2023
@nicolepaschen
Copy link
Member

beta 1 looks good

@nicolepaschen
Copy link
Member

RC1 looks good

jamesros161 added a commit that referenced this pull request Feb 14, 2023
* add filters for prev / next links (#22)

* add action for crio pro (#28)

* add action for crio pro

* undo margin-fix.scss change

* Crio pro issue 114 (#27)

* add action for crio pro

* add color-classes for links to comments

* add comment filters

* update edit exclusions

* update button edit-vars

* update _comments.scss

* set versions

* add show / hide date

* change selector for margin

* add min-height to heading w/ avatar

* add filters for prev / next links (#29)

* add Mega Menus to Pro Features (#8)

* add Mega Menus to Pro Features

* update versions for PR

* Add 'published' or 'modified' post meta date control (#13)

* set versions

* add control and filters for showing updated time

* Add alignment controls for post list 'entry-footer' links (#11)

* add blog page entry-footer link alignment controls

* fix off-center

* re-add missing comment icon controls

* Remove links from page / post / blog / archive titles (#15)

* remove link from page, post, blog & archive titles

* update versions for PR

* fix title color and title font size controls

* update versions

* Add additional feat-image controls for post headers (#17)

* update version for branch

* add templates for featured image positions

* update controls (#16)

* phpcs corrections

* update version for issue-9-alpha

* change bg height control

* add tooltip

* fix image padding / margins

* fix max-full-width flex direction

* MFW fixes

* fix 'hide' not working

* add js to place img inside content

* fix page title divided

* update versions

* update changelog

* minor css fixes

* fix hidden post image not showing on post list

* update versions for RC

* remove % units

* set version for stable

* add comments

* fix file dockblocks

* remove extra lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants