Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Bonsai Changes in 1.0.1 #47

Merged
merged 67 commits into from
Dec 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
596a2c0
Bump up the version to 0.8.6
rkooo567 Jun 8, 2020
16a1873
Linting fix.
rkooo567 Jun 8, 2020
5a6dbcf
Add release test runnning full asan python test (#8836)
simon-mo Jun 8, 2020
668442e
[MERGE TO MASTER] Add microbenchmark result.
rkooo567 Jun 9, 2020
51ba6d5
Fix asyncio re-entry error message (#8842)
simon-mo Jun 9, 2020
e6215d2
Change os.uname()[1] and socket.gethostname() to the portable and fas…
mehrdadn Jun 9, 2020
07112dd
[serve] Fix long running failure test (#8863)
edoakes Jun 9, 2020
429c050
[Serve] Serve long running test fix (#8864)
rkooo567 Jun 9, 2020
226b191
Replace ps call with psutil (#8851)
mehrdadn Jun 9, 2020
3ddf8a4
[Core] Fix a detached actor bug fix when GCS actor management is off.…
rkooo567 Jun 9, 2020
9f151c1
[Testing] Fix LINT/sphinx errors. (#8874)
sven1977 Jun 10, 2020
c3a3b00
Node failure test fix (#8882)
rkooo567 Jun 10, 2020
f6034fd
[core] Check that port is unused before assigning to worker (#8773)
ijrsvt Jun 10, 2020
002e1e7
[rllib] Set framework to tf by default and remove import checks; "Aut…
ericl Jun 9, 2020
a69715e
[RLlib] Issue 8889: action clipping bug ppo not learning mujoco (#8898)
sven1977 Jun 11, 2020
29770cb
Fix Windows build (#8905)
mehrdadn Jun 11, 2020
3d7f61a
Use no_restart=False for ray.kill in Serve failure test (#8952)
stephanie-wang Jun 15, 2020
acf4508
Display GPU Utilization in the Dashboard (#8564)
mfitton Jun 15, 2020
d4009f7
Update incorrect detached actor docs (#8930)
rkooo567 Jun 15, 2020
d506350
[Dashboard] Dashboard pubsub hotfix. (#8944)
rkooo567 Jun 16, 2020
cd75e93
[CI] Fix Conda Permission on MacOS Github Action(#9004)
mehrdadn Jun 18, 2020
2651d24
Update pandas to 1.0.5 (#9065)
mehrdadn Jun 21, 2020
925e9ac
Do not add reference count when it is local mode. (#8979)
rkooo567 Jun 21, 2020
70a081d
[Dashboard] Update the Ray dashboard documentation to explain memory …
rkooo567 Jun 22, 2020
051fdd8
Windows compatibility (#93)
mehrdadn Jun 24, 2020
97782a6
Preparing 0.8.6 (#26)
Edilmo Aug 14, 2020
b7c3473
Fix system info step (#29)
Edilmo Aug 14, 2020
50bcc2c
Fix system info step (#30)
Edilmo Aug 14, 2020
3eba904
adding testing framework (#28)
Aug 18, 2020
2c70d4b
add shared mem max flag
Aug 19, 2020
7c3c414
change readme
Aug 19, 2020
0ed1674
Merge pull request #31 from BonsaiAI/features
Aug 20, 2020
d37016e
Tuned hyperparams for ApexSAC
AdityaGudimella Aug 24, 2020
e22b51f
Bugfix for exploration config.
AdityaGudimella Aug 24, 2020
a895f37
Merge pull request #33 from BonsaiAI/adgudime/apex_sac_tuning
AdityaGudimella Aug 25, 2020
3575aec
Allowing PPO to handle async sampling (#34)
Edilmo Sep 8, 2020
130b053
Fix tflite compat issue (#35)
Edilmo Sep 9, 2020
ee92c5c
Allow replay ops to stop if they are unhealthy (#36)
Edilmo Sep 10, 2020
aca9c76
Making configurable concurrency mode in DQN and metric collection in …
Edilmo Sep 17, 2020
9bc8e18
Fixing concurrency op in dqn (#38)
Edilmo Sep 18, 2020
98ddc2d
Replaced Prioritized Experience Replay with normal Experience replay …
AdityaGudimella Sep 20, 2020
bd81b68
Setting prioritized_replay in config now uses PrioritizedReplay corre…
AdityaGudimella Sep 20, 2020
fde0328
Renamed LocalAsyncReplayBuffer and AsyncReplayActor to better reflect…
AdityaGudimella Sep 21, 2020
46e3cf5
Added test with prioritized_replay set to True
AdityaGudimella Sep 21, 2020
2d260d6
Cleaned up code.
AdityaGudimella Sep 21, 2020
ffb5fe0
Merge pull request #39 from BonsaiAI/adgudime/async_sac
AdityaGudimella Sep 21, 2020
8df94ba
Fixing manual slicing (#40)
Edilmo Sep 21, 2020
6cd9332
Including the force stop in gather_async (#41)
Edilmo Sep 25, 2020
fdfaa81
Making env-runner an explicit iterator and Local Iterator regenerable…
Edilmo Oct 1, 2020
3a1cc92
Improve gathering async and by shards (#44)
Edilmo Oct 5, 2020
036d56e
Make seeding possible even if env cannot be seeded.
AdityaGudimella Oct 9, 2020
2ac6413
Merge branch 'releases/0.8.6' into adgudime/seed_without_env
AdityaGudimella Oct 9, 2020
3a47a19
Merge pull request #45 from BonsaiAI/adgudime/seed_without_env
AdityaGudimella Oct 12, 2020
f33dbde
Fix grep versions (#46)
Edilmo Dec 4, 2020
04101d8
Fixing gitignore
Edilmo Dec 7, 2020
79e84a7
Merge branch 'releases/0.8.6' into edpalenc/1.0.1-bonsai-sync
Edilmo Dec 8, 2020
52ed720
Fixing Sampler merge mistakes
Edilmo Dec 9, 2020
7c31baf
Fixing epsilon greddy merge mistakes and requirements versions
Edilmo Dec 9, 2020
bb1911c
Fix merge error
Edilmo Dec 9, 2020
018bc1d
Apply changes in travis.yml
Edilmo Dec 10, 2020
c79ba84
Fix several issues
Edilmo Dec 14, 2020
dc1cb35
Fixing more compatibility bugs
Edilmo Dec 14, 2020
4db4f0a
Fix more incompatibilities
Edilmo Dec 14, 2020
acd95c9
More incompatibilities
Edilmo Dec 15, 2020
ac77ce8
Fixing more compat issues
Edilmo Dec 15, 2020
0ba209c
Disable tune horovod torch tests
Edilmo Dec 15, 2020
eecb517
Fixing more tests
Edilmo Dec 16, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ build --per_file_copt="-\\.(asm|S)$,external/.*@-w"
# Ignore minor warnings for host tools, which we generally can't control
build:clang-cl --host_copt="-Wno-inconsistent-missing-override"
build:clang-cl --host_copt="-Wno-microsoft-unqualified-friend"
build:clang-cl --host_copt="-Wno-range-loop-analysis"
# This workaround is needed due to https://github.com/bazelbuild/bazel/issues/4341
build --per_file_copt="-\\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGRPC_BAZEL_BUILD"
# Don't generate warnings about kernel features we don't need https://github.com/ray-project/ray/issues/6832
Expand Down Expand Up @@ -90,25 +91,25 @@ test:asan --test_env=LD_PRELOAD="/usr/lib/x86_64-linux-gnu/libasan.so.2 /usr/lib
# test:asan --test_env=LD_PRELOAD="/usr/lib/gcc/x86_64-linux-gnu/7/libasan.so"

# CI configuration:
aquery:ci --color=no
aquery:ci --noshow_progress
build:ci --color=yes
build:ci --curses=no
aquery --color=no
aquery --noshow_progress
build --color=yes
build --curses=no
build:ci --disk_cache=~/ray-bazel-cache
build:ci --keep_going
build --keep_going
build:ci --remote_cache="https://storage.googleapis.com/ray-bazel-cache"
build:ci --progress_report_interval=100
build:ci --show_progress_rate_limit=15
build:ci --show_task_finish
build:ci --ui_actions_shown=1024
build --progress_report_interval=100
build --show_progress_rate_limit=15
build --show_task_finish
build --ui_actions_shown=1024
build:ci-travis --show_timestamps # Travis doesn't have an option to show timestamps, but GitHub Actions does
# GitHub Actions has low disk space, so prefer hardlinks there.
build:ci-github --experimental_repository_cache_hardlinks
test:ci --flaky_test_attempts=3
test:ci --nocache_test_results
test:ci --spawn_strategy=local
test:ci --test_output=errors
test:ci --test_verbose_timeout_warnings
test --flaky_test_attempts=5
test --nocache_test_results
test --spawn_strategy=local
test --test_output=errors
test --test_verbose_timeout_warnings

aquery:get-toolchain --include_commandline=false
aquery:get-toolchain --noimplicit_deps
Expand Down
1 change: 1 addition & 0 deletions .bazelversion
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.4.1
37 changes: 25 additions & 12 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,38 +1,51 @@
# Each line is a file pattern followed by one or more owners.
# See https://help.github.com/articles/about-codeowners/
# for more info about CODEOWNERS file

# It uses the same pattern rule for gitignore file,
# see https://git-scm.com/docs/gitignore#_pattern_format.

# ==== Ray default ====
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# @BonsaiAI/ray-code-owners will be requested for
# review when someone opens a pull request.
* @BonsaiAI/ray-code-owners


# ==== Ray core ====

# All C++ code.
/src/ray @ray-project/ray-core-cpp
/src/ray @BonsaiAI/ray-maintainers

# Python worker.
/python/ray/ @ray-project/ray-core-python
!/python/ray/tune/ @ray-project/ray-core-python
!/python/ray/rllib/ @ray-project/ray-core-python
/python/ray/ @BonsaiAI/ray-maintainers
!/python/ray/tune/ @BonsaiAI/ray-maintainers
!/python/ray/rllib/ @BonsaiAI/ray-maintainers

# Java worker.
/java/ @ray-project/ray-core-java
/java/ @BonsaiAI/ray-maintainers

# Kube Operator.
/deploy/ @BonsaiAI/ray-maintainers

# ==== Libraries and frameworks ====

# Ray tune.
/python/ray/tune/ @ray-project/ray-tune
/python/ray/tune/ @BonsaiAI/ray-code-owners

# RLlib.
/python/ray/rllib/ @ray-project/rllib
/python/ray/rllib/ @BonsaiAI/ray-code-owners
/rllib/ @BonsaiAI/ray-code-owners

# ==== Build and CI ====

# Bazel.
/BUILD.bazel @ray-project/ray-core
/WORKSPACE @ray-project/ray-core
/bazel/ @ray-project/ray-core
/BUILD.bazel @BonsaiAI/ray-code-owners
/WORKSPACE @BonsaiAI/ray-code-owners
/bazel/ @BonsaiAI/ray-code-owners

# CI scripts.
/.travis.yml @ray-project/ray-core
/ci/travis/ @ray-project/ray-core
/.travis.yml @BonsaiAI/ray-maintainers
/ci/ @BonsaiAI/ray-maintainers

14 changes: 13 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
name: CI

on: [push, pull_request]
on:
push:
branches-ignore:
- '**'
# branches:
# - master
# - releases/*
pull_request:
branches-ignore:
- '**'
# branches:
# - master
# - releases/*

env:
# Git GITHUB_... variables are useful for translating Travis environment variables
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# The build output should clearly not be checked in
/bazel-*
/bazel-ray/
/python/ray/core
/python/ray/pickle5_files/
/python/ray/thirdparty_files/
Expand Down Expand Up @@ -183,3 +184,6 @@ tools/prometheus*
# ray project files
project-id
.mypy_cache/

# PyCharm
.ijwb/
2 changes: 1 addition & 1 deletion bazel/ray.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ load("@com_github_checkstyle_java//checkstyle:checkstyle.bzl", "checkstyle_test"
load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
load("@bazel_common//tools/maven:pom_file.bzl", "pom_file")

COPTS = ["-DRAY_USE_GLOG"] + select({
COPTS = ["-DRAY_USE_GLOG", "-Wno-range-loop-analysis"] + select({
"//:opt": ["-DBAZEL_OPT"],
"//conditions:default": [],
}) + select({
Expand Down
4 changes: 2 additions & 2 deletions bazel/ray_deps_setup.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ def ray_deps_setup():

auto_http_archive(
name = "bazel_common",
url = "https://github.com/google/bazel-common/archive/084aadd3b854cad5d5e754a7e7d958ac531e6801.tar.gz",
sha256 = "a6e372118bc961b182a3a86344c0385b6b509882929c6b12dc03bb5084c775d5",
url = "https://github.com/google/bazel-common/archive/bf87eb1a4ddbfc95e215b0897f3edc89b2254a1a.tar.gz",
sha256 = "dab4cbd634aae4bc9b116f4de5737e4d3c0754c3a1d712ad4a9b75140d278614",
)

auto_http_archive(
Expand Down
28 changes: 28 additions & 0 deletions ci/asan_tests/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
SHELL=/bin/bash

echo:
@echo "Available commands: setup, run, recompile"

setup:
echo "Setting up the environment"
pip install -r ray-project/requirements.txt
pip install -U pytest

echo "Installing cython example"
cd "${HOME}"/ray/doc/examples/cython; python setup.py install --user

echo "Settting up the shell"
cp bazelrc "${HOME}"/.bazelrc # Setup cache
echo "LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/7/libasan.so" >> "${HOME}"/.bashrc
echo "ASAN_OPTIONS=detect_leaks=0" >> "${HOME}"/.bashrc

echo "Compiling ray"
cd "${HOME}"/ray; git fetch; git pull origin master
cd "${HOME}"/ray/python; pip install -e . --verbose || true

run:
./run_asan_tests.sh

recompile:
cd "${HOME}"/ray; git fetch; git checkout "${git_sha}"
cd "${HOME}"/ray/python; pip install -e . --verbose || true
30 changes: 30 additions & 0 deletions ci/asan_tests/bazelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# This bazelrc specifies configuration for the release asan test.
# It exists because we want everything to be "default" configuration
# instead of "--config=ci" or "--config=asan".

# Cache
build --remote_cache=https://storage.googleapis.com/ray-bazel-cache
build --disk_cache=/tmp/bazel-cache
build --repository_cache=/tmp/bazel-cache
build --remote_upload_local_results=false

# Asan
build --strip=never
build --copt -g
build --copt -fsanitize=address
build --copt -fno-sanitize=vptr
build --copt -DADDRESS_SANITIZER
build --copt -fno-omit-frame-pointer
build --linkopt -fsanitize=address
build --linkopt -fno-sanitize=vptr
test --action_env=ASAN_OPTIONS=detect_leaks=0
test --action_env=LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/7/libasan.so

# Travis test config
test --flaky_test_attempts=3
test --nocache_test_results
test --show_timestamps
test --spawn_strategy=local
test --test_output=errors
test --test_verbose_timeout_warnings
test --jobs 1
Loading