Preserve original display_name_attribute configuration values.

BookStackApp · Mar 9, 2019 · 6d20bdc · 6d20bdc
1 parent 502ea60
commit 6d20bdc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tests/Auth/LdapTest.php b/tests/Auth/LdapTest.php
@@ -375,6 +375,7 @@ public function test_login_group_mapping_does_not_conflict_with_default_role()
 
     public function test_login_uses_specified_display_name_attribute()
     {
+        $originalAttribute = config('services.ldap.display_name_attribute');
         app('config')->set([
             'services.ldap.display_name_attribute' => 'displayName'
         ]);
@@ -407,12 +408,13 @@ public function test_login_uses_specified_display_name_attribute()
             ->seeInDatabase('users', ['email' => $this->mockUser->email, 'email_confirmed' => false, 'external_auth_id' => $this->mockUser->name, 'name' => 'displayNameAttribute']);
 
         app('config')->set([
-            'services.ldap.display_name_attribute' => 'cn'
+            'services.ldap.display_name_attribute' => $originalAttribute
         ]);
     }
 
     public function test_login_uses_default_display_name_attribute_if_specified_not_present()
     {
+        $originalAttribute = config('services.ldap.display_name_attribute');
         app('config')->set([
             'services.ldap.display_name_attribute' => 'displayName'
         ]);
@@ -444,7 +446,7 @@ public function test_login_uses_default_display_name_attribute_if_specified_not_
             ->seeInDatabase('users', ['email' => $this->mockUser->email, 'email_confirmed' => false, 'external_auth_id' => $this->mockUser->name, 'name' => $this->mockUser->name]);
 
         app('config')->set([
-            'services.ldap.display_name_attribute' => 'cn'
+            'services.ldap.display_name_attribute' => $originalAttribute
         ]);
     }