-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
saml group mapping not working with groups with comma #3405
Comments
Yeah, This is an awkward scenario. |
Yep, that would be nice. Or if you could specify your group attribute delimiter in the .env file and choose between comma, semicolon and other options. |
- Using a backslash in this field before a comma. - Could potentially (Although unlikely) be a breaking change. For #3405
Hi @GustavJer, I'd often add this kind of change into a sooner patch release but since this could potentially be considered a breaking change (although very unlikely), and therefore would require an update notice, it's instead target for the next feature release (Likely end of month). |
I'll close this off since #3416 has been merged. |
- Using a backslash in this field before a comma. - Could potentially (Although unlikely) be a breaking change. For BookStackApp#3405
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
Hi,
Im having some trouble getting SAML group-mapping to work when one of the groups contains a comma. This is while using External Authentication ID on a role to match with the groupname.
This is abit of a problem since our IDP sends the full DN(which contains commas) of the AD-groups that the users is a member of and we need to be able to match these DN´s with roles within Bookstack.
If I send a static string value from our IDP in the groups attribute like "test" and match that to a role in bookstack the group mapping works but if I change it to ",test" in our IDP and in the external auth id field it stops working.
I know that the documentation states that "BookStack will standardise the names of SAML groups to be lower-cased and spaces will be replaced with hyphens." so could it be something similar with commas?
Gustav
Exact BookStack Version
v22.02.3
Log Content
No response
PHP Version
No response
Hosting Environment
Ubuntu LTS 20.04 installed using official installation script.
The text was updated successfully, but these errors were encountered: