Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag view #3042

Merged
merged 3 commits into from
Nov 6, 2021
Merged

Tag view #3042

merged 3 commits into from
Nov 6, 2021

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Nov 6, 2021

As per #738 (comment).

Todo

  • Add link from existing part of application
  • Check permissions are definitely enforced against tag listings
  • Cover with testing

Feature Preview

Pretty much any of the row-items can be clicked through to start a search. The right-most link will provide the same list view but with values shown and the list scoped to just a single tag name.

Screen Shot 2021-11-06 at 21 57 01

- Created listing
- Allows drilldown to tag name
- Shows totals

Not yet covered via testing
- Added from books/shelves listings and within the tag-edit view for all
  entities.
Also:
- Extracted out index table row to its own view.
- Added empty state.
- Ensured query params are set on pagination links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant