Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter and Book Conversion Actions #3499

Merged
merged 11 commits into from
Jun 20, 2022
Merged

Chapter and Book Conversion Actions #3499

merged 11 commits into from
Jun 20, 2022

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Jun 13, 2022 •
edited
Loading

This is primarily intended to add actions for converting chapters to books, and books to shelves as per #1087.

Considerations

  • When a book is converted to a shelf, The book will remain if it contains any direct child pages but will have Pages appended to the name and this book will be added to the new "Converted" shelf.
  • These changes additionally bring in availability to set/update book/shelf cover images via the API.

TODO

These are in-addition to the in-code todos.

  • Move added text to translations.
  • Add tests to cover newly available API shelf/book cover image params.
  • We should show a warning in regards to the difference in permissions for shelves when promoting a book.
  • We should shown a warning about handling direct pages when promoting a book.
  • Test setting book cover image from API
    • Ensure we can update without resetting image accidentally
    • Ensure api docs correct.
    • As all above but for shelves.
  • Add tests to cover each require route permission.

@ssddanbrown
Started work on hierachy conversion actions
d676e1e 
- Updates book/shelf cover image handling for easier cloning/handling.
- Adds core logic for promoting books/chapters up a level.
- Enables usage of book/shelf cover image via API.

Related to #1087
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Jun 13, 2022
@ssddanbrown ssddanbrown self-assigned this Jun 13, 2022
@ssddanbrown ssddanbrown mentioned this pull request Jun 13, 2022
Closed
@ssddanbrown
Added clone of entity permissions on chapter/book promotion
90ec406
@ssddanbrown
Got chapter conversion to books working
8da856b 
- Added required UI within edit view.
- Added required routes and controller actions.
@ssddanbrown
Got book to shelf conversions working
8c67011 
- Also extracted shelf to book view elements to own partial.
- Fixed some existing logic including image param handling in update
  request and activity logging against correct element.
@ssddanbrown
Extracted conversion text to translation file
f145ffc
@ssddanbrown
Added tests to cover convert functionality
663f81a 
Also updated cloner class with typed properties.
@ssddanbrown
Added tests and doc updates for shelf/book cover image API abilities
65d4505
@ssddanbrown
Added tests for content conversion action permissions
85f59b5 
- Updated 'removePermissionFromUser' test helper to work for
  entity-permissions that become part of the joint permissions system.
@ssddanbrown
Applied styleci changes for conversion work
ba25dda
@ssddanbrown
Fixed failing tests after conversion changes
388343a
@ssddanbrown
Removed bad trailing comma in method
8cde362
@ssddanbrown ssddanbrown merged commit be1d691 into development Jun 20, 2022
@ssddanbrown ssddanbrown deleted the convert_hierachy branch June 20, 2022 11:51
@manicmarvin manicmarvin mentioned this pull request Oct 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
🏭 Back-End 🛠️ Enhancement
Milestone
v22.06
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ssddanbrown