Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Gateway docs, improve Secure Payments and enums #309

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

adamgrad
Copy link
Member

@adamgrad adamgrad commented Sep 7, 2019

Screenshots:
Payment Kinds: link
Payment Gateways 1: link
Payment Gateways 2: link
Secure Payments: link

@adamgrad adamgrad self-assigned this Sep 7, 2019
@@ -82,7 +82,9 @@ Here's an example of the expected payload:
"zip": "12312",
"city": "San Francisco",
"state": "California",
"country_code": "US"
"country_code": "US",
"gateway_id": "123",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will also require gateway_type: "PaymentGateway", it's a polymorphic relationship

@@ -168,6 +175,15 @@ travel-cheque | Payment made by Travel Cheque.
wiretransfer | Payment made by Wire Transfer.
{: class="table table-bordered"}

## Payment gateway names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be also Bogus

@adamgrad
Copy link
Member Author

@Azdaroth feedback applied

Copy link
Member

@Azdaroth Azdaroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 🐉 Opa!

@adamgrad adamgrad merged commit 63ab801 into master Sep 19, 2019
@adamgrad adamgrad deleted the improve-payments-docs branch September 19, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants