Fix JoltPhysics compile error on later clang and Xcode #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ol6rin
approved these changes
May 9, 2023
jichumao
added a commit
to jichumao/Piccolo
that referenced
this pull request
Aug 13, 2023
…ngTech#449)" This reverts commit f7a2751.
yazj
added a commit
to yazj/Piccolo
that referenced
this pull request
Sep 13, 2023
…ngTech#449)" This reverts commit f7a2751.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新版本的Clang引入了对未限定的move()等操作的检查，导致JoltPhysics库编译产生大量错误失败。见：https://reviews.llvm.org/D119670
当前版本的JoltPhysics使用了大量using namespace std;，在不修改JoltPhysics源代码的情况下，在CMake引入依赖时增加
-Wno-unqualified-std-cast-call编译选项关闭告警对代码产生的破坏性较小。