Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy button missing on markdown code snippets #315

Closed
evilrix opened this issue Jan 23, 2020 · 9 comments
Closed

Copy button missing on markdown code snippets #315

evilrix opened this issue Jan 23, 2020 · 9 comments
Labels
feature request 🌟 Issue is a new feature request. needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded.
Projects

Comments

@evilrix
Copy link

evilrix commented Jan 23, 2020

Issuehunt badges

Current behavior

The only way to copy a markdown code snippet is to use mouse drag, which is incredibly frustrating. I use Boost Note to save code snippets and commonly executed scripts, which I just copy/paste and the lack of a way to easily select these snippets make it very difficult to use.

Expected behavior

I'm sure the previous version of Boost Note used to have a little button you could click to copy the entire code block into the Windows clipboard.

Steps to reproduce

Create sine markdown that includes a code block. Attempt to copy the code snippet. It can only be done my clicking and dragging the mouse. With multiple lines this isn't too bad, but with one line snippets it's almost impossible to select the line.

Environment

Windows 10, 1909.


IssueHunt Summary

zerox-dg zerox-dg has been rewarded.

Backers (Total: $5.00)

Submitted pull Requests


Tips

@Flexo013 Flexo013 added the feature request 🌟 Issue is a new feature request. label Jan 28, 2020
@Flexo013
Copy link
Contributor

Flexo013 commented Feb 9, 2020

Example from this button in the old app:
image

New app:
image

@Rokt33r Rokt33r added this to To do in Dev kanban Feb 13, 2020
@evilrix
Copy link
Author

evilrix commented Feb 17, 2020

It's also worth noting that line numbers are missing in the new version. Happy to create a new ticket for this if appropriate. Thank you.

@Flexo013
Copy link
Contributor

I imagine this ticket will be fine. If somebody only wants to implement one or the other by submit a separate PR then we can make a separate ticket for the separate feature.

@wjrivera
Copy link

wjrivera commented Jul 6, 2020

Is this feature request currently on the development pipeline?

@Flexo013
Copy link
Contributor

Flexo013 commented Jul 6, 2020

@wjrivera Not specifically. It's planned, but nobody has picked up this request yet.

You can always 👍 this issue at the top, to help show how many people are interested. Additionally you can fund this issue on IssueHunt: https://issuehunt.io/r/BoostIO/BoostNote.next

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 7, 2020

@wjrivera has funded $5.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. label Jul 7, 2020
@meinenec
Copy link

meinenec commented Jul 31, 2020

Running Boost Note 8.2 on macOS 10.14.6

The copy button is now there (from #560 I believe) but clicking it doesn't actually copy to my clipboard.

Either way I'm excited to see progress.

@Flexo013 Flexo013 added the needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. label Aug 2, 2020
@Rokt33r Rokt33r closed this as completed Aug 14, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Aug 14, 2020

Closed. The feature has been already implemented. And the bug(#315 (comment)) will be handled in #585

@issuehunt-oss
Copy link

issuehunt-oss bot commented Aug 14, 2020

@rokt33r has rewarded $4.50 to @zerox-dg. See it on IssueHunt

  • 💰 Total deposit: $5.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $0.50

@issuehunt-oss issuehunt-oss bot added rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded. and removed funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. labels Aug 14, 2020
@Rokt33r Rokt33r moved this from To do (Medium) to Done in Dev kanban Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request. needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. rewarded on issuehunt 🎁 Issue has been resolved and a contributor has been rewarded.
Projects
No open projects
Dev kanban
  
Done
5 participants