Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag enhancements #2314

Merged
merged 9 commits into from
Nov 6, 2018
Merged

tag enhancements #2314

merged 9 commits into from
Nov 6, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Aug 20, 2018

This change add 2 new options:

  • showTagsAlphabetically: show tags of a note in alphabetical order.
  • enableLiveNoteCounts: enable live count of notes in the Side Bar. (tags without any related notes have no displayed count)

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 22, 2018
@ghost
Copy link

ghost commented Aug 28, 2018

hi, would it make sense to sort the tags only once when they are created (and store in this order in file), instead of every time the note is displayed?

sorry if this suggestion doesn't make sense. I am not exactly sure what your changes does.

@daiyam
Copy link
Contributor Author

daiyam commented Aug 28, 2018

@modmod24 no, it does make sense. But what about the existing tags?

Maybe the option saveTagsAlphabetically should be added or should replace showTagsAlphabetically .
That option is shown with a warning that by selecting it, it would sort the existing tags.
There might be a performance issue since we will have to re-save all the notes; same issue when we will be able to rename a tag...

@ghost
Copy link

ghost commented Aug 29, 2018

@daiyam I was thinking about ordering only when saving tags, to prevent frequently ordering what's already in order. existing order would remain until new tag added.


Edit: for a user preference everything must be in order, but it might be suited for integrated behaviour instead.

@daiyam
Copy link
Contributor Author

daiyam commented Aug 29, 2018

@modmod24 I will add the option saveTagsAlphabetically as you have described.
But I will keep the option showTagsAlphabetically so it will be up to the user to select which one to select. Is that ok?

@ghost
Copy link

ghost commented Aug 30, 2018

yes, of course. thanks.

@Rokt33r
Copy link
Member

Rokt33r commented Sep 15, 2018

enableLiveNoteCounts: enable live count of notes in the Side Bar. (tags without any related notes have no displayed count)

Could you tell me more what it is?

@daiyam
Copy link
Contributor Author

daiyam commented Sep 15, 2018

@Rokt33r here some screenshots to explain it better:

When enableLiveNoteCounts is off (by default):
screenshot

When enableLiveNoteCounts is on:
screenshot

The count on bug isn't shown because there is no notes with feature and bug tags.
The count on table is 1 instead of 4 because only one note has both feature and table tags.

@Rokt33r Rokt33r added next release (v0.11.12) and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 6, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Nov 6, 2018

I confirmed it works fine. Sorry for being late! 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants