Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the scroll bar when the tag list is overflow #2720

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

richardtks
Copy link
Contributor

Description

When the number of tags exceed the width of the window, scroll bar is not showing.

Issue fixed

#2688

Type of changes

  • πŸ”˜ Bug fix (Change that fixed an issue)
  • βšͺ Breaking change (Change that can cause existing functionality to change)
  • βšͺ Improvement (Change that improves the code. Maybe performance or development improvement)
  • βšͺ Feature (Change that adds new functionality)
  • βšͺ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • πŸ”˜ My code follows the project code style
  • βšͺ I have written test for my code and it has been tested
  • πŸ”˜ All existing tests have been passed
  • πŸ”˜ I have attached a screenshot/video to visualize my change if possible

Screenshot:

image

@@ -3,15 +3,12 @@
align-items center
user-select none
vertical-align middle
width 100%
width 96%
overflow-x scroll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change overflow-x scroll to overflow-x auto so the scroll bar is shown only when needed πŸ˜‰

Copy link
Contributor Author

@richardtks richardtks Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@daiyam, Even without overflow-x auto, the scroll bar will not show by default unless the tag list is overflow, not sure why the behavior is like this....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the update.

With overflow-x scroll, I have:
screenshot
The space bellow is for the scrollbar but the thumb isn't yet shown

With overflow-x auto, I have:
screenshot
Same design as on the master.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 19, 2018
@ZeroX-DG
Copy link
Member

The scrollbar is a too big I think. Also, the tag list is overlapped by the toggle button.
ba

@ZeroX-DG ZeroX-DG added awaiting changes πŸ–ŠοΈ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 19, 2018
@richardtks
Copy link
Contributor Author

With scroll bar:
image

Without scrollbar:
image

@ZeroX-DG, @daiyam, I slim down the scrollbar, is it looks ok for you guys? if you guys are ok, then I will push my changes. πŸ˜„

@ZeroX-DG
Copy link
Member

Yeah I think it looks good !

@ZeroX-DG
Copy link
Member

@richardtks can you push your code?

@richardtks
Copy link
Contributor Author

@ZeroX-DG, Sorry, I missed out your reply. I have pushed the code. Please check πŸ˜„

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

@ZeroX-DG ZeroX-DG added approved πŸ‘ Pull request has been approved by sufficient reviewers. and removed awaiting changes πŸ–ŠοΈ Pull request has been reviewed, but contributor needs to make changes. labels Dec 29, 2018
@Rokt33r Rokt33r added next release (v0.11.13) and removed approved πŸ‘ Pull request has been approved by sufficient reviewers. labels Jan 7, 2019
@Rokt33r Rokt33r merged commit 99cb6fa into BoostIO:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants