Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show the scroll bar when the tag list is overflow #2720

Merged
merged 3 commits into from
Jan 7, 2019
Merged

show the scroll bar when the tag list is overflow #2720

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b1ec3f
show the scroll bar when the tag list is overflow
richardtks Dec 18, 2018
bb892f7
Updated the overflow-x to auto
richardtks Dec 18, 2018
48a905b
decrease the height of tags scrollbar
richardtks Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions browser/main/Detail/TagSelect.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,12 @@
align-items center
user-select none
vertical-align middle
width 100%
width 96%
overflow-x scroll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change overflow-x scroll to overflow-x auto so the scroll bar is shown only when needed 😉

Copy link
Contributor Author

@richardtks richardtks Dec 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@daiyam, Even without overflow-x auto, the scroll bar will not show by default unless the tag list is overflow, not sure why the behavior is like this....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the update.

With overflow-x scroll, I have:
screenshot
The space bellow is for the scrollbar but the thumb isn't yet shown

With overflow-x auto, I have:
screenshot
Same design as on the master.

white-space nowrap
margin-top 31px
position absolute

.root::-webkit-scrollbar
display none

.tag
display flex
align-items center
Expand Down