fix image path due to bad regex #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d that issue in the future + test modified so that they both contain tests for posix and windows path separator -> fixes BoostIO#2834
- improve test - fix missing 'e' in some functions name
|
No more findings on this branch. We will keep this comment up-to-date as you go along and notify you of any security issues that we identify. Happy with the results? Give your feedback. |
|
Awesome! I'll test this today!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is base on the work of @ehhc (PR #2835).
The difference is that it won't break the gallery feature and improve a test to correctly assert all image paths are correctly generated.
Issue fixed
Type of changes
Checklist: