Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app name and icon on linux #806

Merged
merged 2 commits into from
Aug 18, 2017
Merged

Fix app name and icon on linux #806

merged 2 commits into from
Aug 18, 2017

Conversation

sferra
Copy link
Contributor

@sferra sferra commented Aug 15, 2017

Follow-up on pull request 534
Sorry for the delay.

Fixes the incorrect application icon in linux/gnome-shell. See
#251
Fixes incorrect application name displayed in linux/gnome-shell. See
#251
@yashha
Copy link

yashha commented Aug 15, 2017

Thanks! LGTM, just checked it

@kazup01
Copy link
Member

kazup01 commented Aug 15, 2017

Thanks @sferra !

@yashha
Copy link

yashha commented Aug 15, 2017

Wait the application name is "Electron" on my test?
screenshot from 2017-08-15 14-15-52
I'm using https://extensions.gnome.org/extension/307/dash-to-dock/

@sferra
Copy link
Contributor Author

sferra commented Aug 15, 2017

@yashha I am AFK for the next 24 hours, so I'm afraid I can't verify that.
Could you please disable dash-to-dock (just for testing) and check if the effect is the same?

@yashha
Copy link

yashha commented Aug 15, 2017

Same when it is deactivated.
screenshot from 2017-08-15 14-32-41

@sferra
Copy link
Contributor Author

sferra commented Aug 15, 2017

I'll verify as soon as possible.

@yashha
Copy link

yashha commented Aug 15, 2017

Maybe it changes, when packaging and installing it.
On run-dev it it like that.

@yashha
Copy link

yashha commented Aug 15, 2017

It works after packaging.
screenshot from 2017-08-15 15-20-56
So lgtm.

@sferra
Copy link
Contributor Author

sferra commented Aug 15, 2017

Thank you for testing. Please let me know if there is anything else I can do.

@asmsuechan
Copy link
Contributor

environment

Ubuntu 16.04 LTS

before

yarn run dev-start
image

grunt pre-build
image

after

yarn run dev-start
screenshot from 2017-08-18 18-05-00

grunt pre-build
screenshot from 2017-08-18 18-40-28

Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much indeed!

@asmsuechan asmsuechan merged commit 2899264 into BoostIO:master Aug 18, 2017
@sferra sferra deleted the fix-app-name-and-icon-on-linux branch August 18, 2017 10:34
@kazup01 kazup01 mentioned this pull request Sep 23, 2017
@kazup01 kazup01 mentioned this pull request Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants