Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix route when selecting multiple tags #2600

Merged
merged 1 commit into from
Nov 12, 2018
Merged

fix route when selecting multiple tags #2600

merged 1 commit into from
Nov 12, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Nov 11, 2018

Description

The change fixes the route when selecting multiple tags (since Electron v3).

When selecting the tags hello and world,

  • on Electron v2, the route was /tags/hello world
  • on Electron v3, the route is /tags/hello%20world

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@daiyam daiyam mentioned this pull request Nov 11, 2018
Merged
ZeroX-DG
ZeroX-DG approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added the approved 👍 Pull request has been approved by sufficient reviewers. label Nov 11, 2018
@daiyam
Copy link
Contributor Author

daiyam commented Nov 12, 2018

@Rokt33r this PR should be merged for the next release since it fixes a serious bug with the tag list.

@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 12, 2018
@Rokt33r Rokt33r merged commit 30e6fc5 into BoostIO:master Nov 12, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Nov 12, 2018

Awesome!

@daiyam daiyam deleted the fix-taglist branch November 12, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daiyam @Rokt33r @ZeroX-DG