Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support cancel transfer #246

Closed
urushibata-k opened this issue Dec 16, 2021 · 1 comment · Fixed by #260
Closed

[FEATURE] Support cancel transfer #246

urushibata-k opened this issue Dec 16, 2021 · 1 comment · Fixed by #260
Assignees
@YoshihitoAso @urushibata-k
Labels
enhancement New feature or request
Projects
v22.3.0

Comments

@urushibata-k
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Currently, tokens that require transfer approval only implemented approve.
  • So, it support for cancel.

Describe the solution you'd like

  • Add the operate_type parameter to the POST API and cancel the transfer application if cancel.(Cannot be canceled with exchange contract)
  • Add Issuer cancelable to GET API response.
@urushibata-k urushibata-k added the enhancement New feature or request label Dec 16, 2021
@urushibata-k
Copy link
Collaborator Author

urushibata-k commented Dec 16, 2021 •
edited

Implemented
https://github.com/BoostryJP/ibet-Prime/tree/feature/%23246

urushibata-k added a commit that referenced this issue Dec 21, 2021
@urushibata-k
Merge branch 'feature/#246' into feature/#247
0d9c6e4
urushibata-k added a commit that referenced this issue Dec 22, 2021
@urushibata-k
Merge branch 'feature/#246' into feature/#248
a61f3b4
This was referenced Jan 17, 2022
Merged
Closed
@YoshihitoAso YoshihitoAso added this to In progress in v22.3.0 Jan 26, 2022
v22.3.0 automation moved this from In progress to Done Jan 26, 2022
YoshihitoAso added a commit that referenced this issue Jan 26, 2022
@YoshihitoAso
Merge pull request #260 from BoostryJP/feature/#246
7968b5d 
feat: cancel transfer approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoshihitoAso YoshihitoAso

@urushibata-k urushibata-k

Labels
enhancement New feature or request
Projects
No open projects
v22.3.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cancel transfer approval BoostryJP/ibet-Prime
2 participants
@YoshihitoAso @urushibata-k