Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] filter unapproved for the transfer approval history API #248

Closed
urushibata-k opened this issue Dec 16, 2021 · 2 comments · Fixed by #264
Closed

[FEATURE] filter unapproved for the transfer approval history API #248

urushibata-k opened this issue Dec 16, 2021 · 2 comments · Fixed by #264
Assignees
@YoshihitoAso @urushibata-k
Labels
enhancement New feature or request
Projects
v22.3.0

Comments

@urushibata-k
Copy link
Collaborator

urushibata-k commented Dec 16, 2021 •
edited

Is your feature request related to a problem? Please describe.
filter unapproved for the transfer approval history API

Describe the solution you'd like
Add filter item.

  • status: unapproved, approved, transferred, canceled
  • from_address
  • to_address
  • is_issuer_cancelable: add item from feature/#246
@urushibata-k urushibata-k added the enhancement New feature or request label Dec 16, 2021
@urushibata-k
Copy link
Collaborator Author

And add GET: /share/transfer_approvals and GET: /bond/transfer_approvals.

  • issuer_address: header param
  • token_address

urushibata-k added a commit that referenced this issue Dec 22, 2021
@urushibata-k
Merge branch 'feature/#246' into feature/#248
a61f3b4
@YoshihitoAso YoshihitoAso added this to To do in v22.3.0 via automation Jan 4, 2022
@urushibata-k
Copy link
Collaborator Author

Sotrable and fillterable to the transfer approval API
image

This was referenced Jan 19, 2022
Merged
Closed
Merged
v22.3.0 automation moved this from To do to Done Jan 21, 2022
YoshihitoAso added a commit that referenced this issue Jan 21, 2022
@YoshihitoAso
Merge pull request #264 from BoostryJP/feature/#248
5a329ac 
feat: sotrable and fillterable to the transfer approval API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoshihitoAso YoshihitoAso

@urushibata-k urushibata-k

Labels
enhancement New feature or request
Projects
No open projects
v22.3.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sotrable and fillterable to the transfer approval API BoostryJP/ibet-Prime
2 participants
@YoshihitoAso @urushibata-k