End-Of-File error of some WMAs

[jirihajek]

Parsing of some WMAs returns error:

Error: End-Of-File
at c:\mms\mms\node_modules\strtok3\lib\FileTokenizer.js:45:23

Sample file attached.

sample.zip

[Borewit]

Should music-metadata be able to parse truncated or corrupted files?
Therefor related to:

• Improve the music metadata reading and updating mechanism webtorrent/webtorrent-desktop#1340
• Added unit test to read incomplete mp3 file; added incomplete mp3 file. #64 (comment)
• Return metadata quality information #60: Return metadata quality information

[Borewit]

@jirihajek: Your feedback is highly appreciated.

Fixed in: v0.9.11

[jirihajek]

Thanks for the fix! I can confirm that it works well now.

Should music-metadata be able to parse truncated or corrupted files?

In my experience tags are corrupted in some way quite often, which stems from buggy software, but also some lose interpretations of standards, or incomplete files. So, most tag reading libraries accept various forms of corruption, or let's say tags that don't follow specs -- otherwise they look like being buggy compared to other tag readers.

It certainly shouldn't go too far, e.g. to risk crashes of the tag reading library, but whatever can be parsed within some limits of the specs, should, imho, be tried to parsed.

[Borewit]

I agree with that.

My comment was also intended as a personal placeholder to follow with some longer term improvement.

One of the references goes back to the use case of the web-torrent application, which is using this parser to parse incomplete files.