-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End-Of-File error of some WMAs #68
Comments
Should music-metadata be able to parse truncated or corrupted files? |
@jirihajek: Your feedback is highly appreciated. Fixed in: v0.9.11 |
Thanks for the fix! I can confirm that it works well now.
In my experience tags are corrupted in some way quite often, which stems from buggy software, but also some lose interpretations of standards, or incomplete files. So, most tag reading libraries accept various forms of corruption, or let's say tags that don't follow specs -- otherwise they look like being buggy compared to other tag readers. It certainly shouldn't go too far, e.g. to risk crashes of the tag reading library, but whatever can be parsed within some limits of the specs, should, imho, be tried to parsed. |
I agree with that. My comment was also intended as a personal placeholder to follow with some longer term improvement. One of the references goes back to the use case of the web-torrent application, which is using this parser to parse incomplete files. |
Parsing of some WMAs returns error:
Error: End-Of-File
at c:\mms\mms\node_modules\strtok3\lib\FileTokenizer.js:45:23
Sample file attached.
sample.zip
The text was updated successfully, but these errors were encountered: