Release Date tag support #1648
Merged
Release Date tag support #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smal fix for the Release Date (
TDRL) frame as per id3v2.4, and in other formats.This makes it in line with most other tag libraries/editors, see also mp3tag, TagLib, kid3, mutagen:
date->TDRCoriginaldate->TDORreleasedate->TDRLIt fails the test for pr-544, but that's 'correct': if you look at the test file
pr-544-id3v24.mp3, it has a value inTDRL(=releasedate), while the test written for it tests the emptyTDRC(=date) frame -> logically it fails. It worked before, because TDRL was erroneously mapped todateinstead ofreleasedate)I can do two things:
date(TDRC) instead (then the test will work again)releasedate