Feature/riff wave merge phw #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the same format as TXXX now. Since the ":" separator is a bit tricky with URLs as values add some examples to the man page. The previous WXXX behaviour where it was storing the repr of the value list was just working by accident. Also add some more tests for other URL frames and multiple T/WXXX arguments.
Lame encodes the value as: abs((int) ((((FLOAT) gfc->ov_rpg.PeakSample) / 32767.0) * pow(2, 23) + .5)) (int)(float_num + 0.5) is just an easy way to round number to the nearest integer. There is no need to subtract 0.5 while decoding. Doing so will add an error (though very small).
Small fix to peak amplitude decoding
for the new pyflakes release
Read it from the fmt chunk. I can't find a proper spec right now, but this is what taglib does and it seems to work :)
This reverts commit be4b3ca.
This reverts commit 67d6d61.
this worked with pycairo
…uodlibet#349 Typo which made it fall through to the next case.
mp4: fix 8bit ints getting saved as 16bit (rtng, stik, shwm). Fixes quodlibet#349
Related to issue quodlibet#207
Remove duplicate code between wave.py and _riff.py
Ref: - quodlibet#321 (comment) - a5c3785ed8d6a35868bc169f07e40e889087fd2e
…should be a text type
* fix wrong abstract attribute reference
* fix reference to root ('RIFF') chuck
…f-wave-merge-phw # Conflicts: # mutagen/_riff.py # mutagen/wave.py # tests/test___init__.py # tests/test_wave.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.