Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception if jsObservable loaded before jsRender #240

Closed
benmetheny opened this issue Jan 17, 2014 · 4 comments
Closed

Exception if jsObservable loaded before jsRender #240

benmetheny opened this issue Jan 17, 2014 · 4 comments

Comments

@benmetheny
Copy link

On line 556 of jsObservable an attempt is made to set $.views.sub.DataMap when $.view.sub is undefined this fails. This is taken care of on line 27 by assigning a $viewsSub variable, looks like this one line doesn't use that variable.
@BorisMoore
Copy link
Owner

Thanks. I have a fix on the way for this...

BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Jan 22, 2014
@BorisMoore
Commit 50 (Beta Candidate)
bcd0f86 
- Added support for getting full path in observeAll from
  root to modified object (including array indices):
  ev.data.observeAll.path()
- Added support for getting parent chain in observeAll
  from modified object to root:
  ev.data.observeAll.parents()
- Bug fix in {^{props}} data linking
- Fix for BorisMoore/jsviews#240
- Fix for BorisMoore/jsrender#228
BorisMoore added a commit that referenced this issue Jan 22, 2014
@BorisMoore
Commit 50 (Beta Candidate)
4426870 
- Added support for getting full path in observeAll from
  root to modified object (including array indices):
  ev.data.observeAll.path()
- Added support for getting parent chain in observeAll
  from modified object to root:
  ev.data.observeAll.parents()
- Bug fix in {^{props}} data linking
- Fix for #240
- Fix for BorisMoore/jsrender#228
@BorisMoore
Copy link
Owner

@benmetheny: This has been fixed in commit 50. Can you verify that the fix works for you? Thanks!

@benmetheny
Copy link
Author

It's working fine for me now, thanks.

@BorisMoore
Copy link
Owner

Thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BorisMoore @benmetheny