Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not log unloggable context #207

Merged
merged 1 commit into from
Jul 9, 2018
Merged

fix: Do not log unloggable context #207

merged 1 commit into from
Jul 9, 2018

Conversation

michelbl
Copy link
Contributor

@michelbl michelbl commented Jul 9, 2018

@michelbl michelbl requested a review from Benjamin15 July 9, 2018 12:10
@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #207   +/-   ##
=====================================
  Coverage      89%    89%           
=====================================
  Files          78     78           
  Lines        1573   1573           
  Branches      201    201           
=====================================
  Hits         1400   1400           
  Misses        147    147           
  Partials       26     26
Impacted Files Coverage Δ
packages/botfuel-dialog/src/nlus/botfuel-nlu.js 86.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105c649...131137c. Read the comment docs.

@michelbl michelbl merged commit 5d6fb9c into master Jul 9, 2018
@michelbl michelbl deleted the fix-log branch July 9, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants