Automatic Error Recovery #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/2.0.0 #45 +/- ##
=================================================
- Coverage 96.91% 96.27% -0.64%
=================================================
Files 31 33 +2
Lines 1068 1208 +140
=================================================
+ Hits 1035 1163 +128
- Misses 33 45 +12
Continue to review full report at Codecov.
|
tylermilner
approved these changes
May 18, 2018
| BackendServiceHelper.handleResponse(response, completion: completion) | ||
|
|
||
| case .failure(let error): | ||
| guard let recoveryStrategy = self?.recoveryStrategy else { return completion(.failure(error)) } |
There was a problem hiding this comment.
For the else on this guard, do we need to pipe it through BackendServerHelper so that the completion block gets run on the main thread?
There was a problem hiding this comment.
Good catch. We very much do. Will tweak that now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another large feature that I want to get in before 2.0 pre-release if possible. Essentially, this does the following:
Recoverable, which dictates when an arbitrary operation can be recovered from and re-attempted. Also adds an extension onRecoverablefor easily preparing subsequent attempts.BackendService(should it be a part of theBackendServiceProtocol?) for aRequestRecoveryStrategy. This object allows for certain errors to be handled automatically by returning a specificRecoveryDispositionofretryorfail.For example: If the error returned is a 401 unauthorized, the recovery strategy can add the appropriate authorization header to the request, and return
retry.I can look into a subspec if we think that it belongs in one.