Review #1

Bouh · Dec 21, 2019 · 3e8f00b · 3e8f00b
1 parent 5a9b183
commit 3e8f00b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/Extensions/Effects/JsExtension.js b/Extensions/Effects/JsExtension.js
@@ -160,16 +160,18 @@ module.exports = {
     );
     displacementProperties.set(
       "scaleX",
-      new gd.PropertyDescriptor(/* defaultValue=20 */ "20")
+      new gd.PropertyDescriptor(/* defaultValue= */ "20")
         .setLabel(_("Scale X"))
         .setType("number")
     );
     displacementProperties.set(
       "scaleY",
-      new gd.PropertyDescriptor(/* defaultValue=20 */ "20")
+      new gd.PropertyDescriptor(/* defaultValue= */ "20")
         .setLabel(_("Scale Y"))
         .setType("number")
     );
+
+    return extension;
   },
   runExtensionSanityTests: function(gd, extension) {
     return [];

diff --git a/Extensions/Effects/displacement-pixi-filter.js b/Extensions/Effects/displacement-pixi-filter.js
@@ -9,7 +9,12 @@ gdjs.PixiFiltersTools.registerFilterCreator("Displacement", {
 
     return displacementFilter;
   },
-
+  updateBooleanParameters: function(filter, parameterName, value) {
+    return;
+  },
+  updateDoubleParameters: function(filter, parameterName, value) {
+    return;
+  },
   updateStringParameters: function(filter, parameterName, value) {
     if (filter === "scaleX") {
       filter.scale.x = value;