Ensure access to characteristics happen on the main queue. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econdition on set characteristic value
…least 1155 bytes. Add back the debug logging to root() to help fix configuration issues.
|
Added workaround mentioned in #77 to ensure a minimum buffer size larger than 1155 for messages from HK. Also added the debug message in root() to log the message sent to HomeKit to help fix issues in communications or configuration. The original version has a spelling mistake ("messagea") which was useful for locating it in the logs, so I preserved the spelling mistake ! |
…erver connection.
|
The Tests were running on the main queue, which doesn't happen under normal operations. I've modified the characteristic tests to run from a separate queue, simulating a NIO thread. |
Bouke
requested changes
Feb 26, 2019
Bouke
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small changes.
First change corrects the precondition on set characteristic value.
Secondly, the characteristic endpoint is currently running on a NIO queue, causing thread safety issues.
This PR performs the endpoint on the main queue, to ensure a single queue access the HAP characteristics. A future improvement could be to restructure the entire endpoint architecture to use promises, which would avoid a synchronous call across queues.