GPUImageMovie endprocessing crash issue. #2544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVPlayerItemVideoOutput property inside GPUImageMovie sets videoProcessingQueue as a delegate, so when GPUImageMovie is deallocating, AVPlayerItemVideoOutput won't release then the crash occurs. To fix it, AVPlayerItemVideoOutput needs to be released when the process ends. Hence the following codes are provided at the end of endProcessing method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVPlayerItemVideoOutput property inside GPUImageMovie sets videoProcessingQueue as a delegate, so when GPUImageMovie is deallocating, AVPlayerItemVideoOutput won't release then the crash occurs. To fix it, we need to make sure that AVPlayerItemVideoOutput is released properly when the process ends. Hence the following codes are provided at the end of endProcessing method.
References:
#1994
https://stackoverflow.com/questions/29103254/copy-helper-block-crash-in-avfoundation