Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

support send attachment is instance of MINEBase #32

Closed
wants to merge 1 commit into from

Conversation

x007007007
Copy link

According to django document, attribution attachments can be MIMEBase, if don't support that features, I don't know how to send inline attachment. I fix that, It look like work well.

@pydanny
Copy link
Collaborator

pydanny commented Nov 5, 2015

@x007007007 Thanks for the pull request! My one question is how exactly is this used? Let me know and I'll accept this and document what you say.

@vstoykov
Copy link
Contributor

vstoykov commented Mar 9, 2016

As what I see you can pass attachment to be different than tuple or list, and more precisely to be based of email.mime.base.MIMEBase. This probably is good if something else was constructed the attachment for you (some lib or whatever).

My suggestion about this PR is that the check for MIMEBase need to be first and to fallback to directly try to get 0 and 1 element instead of checking for if it is a list or tuple.

@x007007007
Copy link
Author

you are right

@x007007007 x007007007 closed this Apr 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants