Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring #28

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Small refactoring #28

merged 2 commits into from
Nov 6, 2020

Conversation

andrey-zherikov
Copy link
Contributor

No description provided.

BradleyChatha
BradleyChatha requested changes Nov 6, 2020
View reviewed changes
Copy link
Owner

@BradleyChatha BradleyChatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll mark a few places where the formatting messed up slightly.

You've also made me aware that the Github Actions aren't specified to run on pull requests.

@BradleyChatha
Update core.d
b9c8385 
Still learning what you can actually do with Github. Would've done this first instead of the comment spam.
@BradleyChatha BradleyChatha merged commit 0466efa into BradleyChatha:master Nov 6, 2020
@andrey-zherikov andrey-zherikov deleted the refactoring branch November 7, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleyChatha BradleyChatha BradleyChatha requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrey-zherikov @BradleyChatha