Rewrite of argparser, commandparser, argbinder and the introspect #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote virtually from scratch the argparser, commandparser, argbinder and the introspect module.
The stuff I wrote mostly comes with unit tests (only the argbinder module does not).
I have left the general interface overall unchanged, but the documentation should be updated and the examples must be broken.
There are a few breaking changes from the behavior perspective. The
parseAsFlagargument flag corresponds to the now replaced_boolparse scheme. It used to be opt-in by default, without the option to opt out of it (I think). Right now it is never inferred.I've changed a few function and template names, like
ConverterFunctioninstead ofBindWith, but those can be brought back by aliasing the new versions. I agree that the shorter names might be more convenient for the user, but the new names make way more sense internally.There must be a couple more things like this, but I can't think of them right now.