Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shading issues with cartoon geometry #268

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Conversation

BradyAJohnston
Copy link
Owner

fixes #267 and fixes #259 shading issues

fixes #267 and fixes #259 shading issues
@BradyAJohnston BradyAJohnston marked this pull request as ready for review July 13, 2023 06:57
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (594ddeb) 56.25% compared to head (88d317f) 56.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files          15       15           
  Lines        1943     1943           
=======================================
  Hits         1093     1093           
  Misses        850      850           
Impacted Files Coverage Δ
MolecularNodes/__init__.py 63.63% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradyAJohnston BradyAJohnston merged commit 2c49418 into main Jul 15, 2023
4 of 5 checks passed
@BradyAJohnston BradyAJohnston deleted the dev-fix-cartoon branch July 15, 2023 02:41
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
fix shading issues with cartoon geometry
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
fix shading issues with cartoon geometry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant