Stub _n_noop, _nx_noop, translate_nooped_plural #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stub for those were missing in stubTranslationFunctions() See #51
jrfnl
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Verified against the WP functions and LGTM. Useful addition IMO.
I do see a risk with translate_nooped_plural potentially showing "undefined array index" notices, but I'm not concerned about that, as that would indicate a code error anyway, so if tests error out on that, all the better!
(Can I merge it or will you merge it yourself ?)
jrfnl
requested changes
Dec 13, 2022
paulshryock
added a commit
to paulshryock/BrainMonkey
that referenced
this pull request
Mar 1, 2023
Closes Brain-WP#51, completes Brain-WP#131
|
I added PR #133 which adds tests into this branch, to unblock this PR. |
|
Thanks, @jrfnl for the review. I think this is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stub for
_n_noop(),_nx_noop(), andtranslate_nooped_plural()were missing instubTranslationFunctions()See #51