Display mod icon in modlist #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Affehund <affehund@Air-von-Daniel.fritz.box> Co-authored-by: matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
# Conflicts: # src/mixin/resources/brassloader.mixins.json
|
This seems to be including some of the commits from the previous things that maty submitted? |
|
I had to update the modlist branch to use some things from previous pr in the master branch, e.g. the SecureJar in the ModContainer which was added by maty in some previous prs. |
|
In that case, maybe it would be better if I pulled master to ModList that as a separate PR. |
|
You can do that, but then I have to revert all those commits somehow. |
|
I believe this is still including changes that are already present? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.