-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor + Cleanup ScanContext #33
Comments
Further complexity reduction can be achieved by re-using certain classes/modules from PySceneDetect, as well as reduce code duplication. In particular:
The only downside to having |
After this change, FrameTimecode can be deprecated & removed in place of scenedetect.FrameTimecode seamlessly.
Add new _select_roi method to ScanContext. Add new _create_progress_bar method to ScanContext. Make line argument of ScanContext._stamp_text method optional. Rename roi and draw_timestamp properties to indicate private.
Replacements with equivalents will not happen until v2.0. Right now focus should be on minimum changes to get basic testing functionality up and running, and close out development of v1.x right after to focus on 2.0. |
The number of lines in the
scan_motion()
method ofScanContext
is quite high, and lots of development artifacts still exist. Cleanup and reduce max function length by breaking existing method down into smaller parts, to improve reusability + eventual integration with new PySceneDetect API.The text was updated successfully, but these errors were encountered: