Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player State Endpoint/Game Start #34

Merged
merged 15 commits into from
Sep 9, 2019
Merged

Player State Endpoint/Game Start #34

merged 15 commits into from
Sep 9, 2019

Commits on Sep 7, 2019

  1. Add initial spec for Player State endpoint, calling on Game.start method 

    Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    768aa60 View commit details
    Browse the repository at this point in the history

  2. Add initial spec for Game#start method to create GameCards and assign… 

    … GameCards to Players

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    ca16047 View commit details
    Browse the repository at this point in the history

  3. Change to game.cards in Game#start spec to avoid unnecessary joins wi… 

    …th GameCards

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
Co-Authored-By: Chris Davis <davisc1014@gmail.com>
    @Patrick-Duvall @DavisC0801
    3 people committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    bab9be6 View commit details
    Browse the repository at this point in the history

  4. Add initial #start method for Game that adds Copper and Estates to Pl… 

    …ayer GameCards, and adds Coppers and Estates to pool of GameCards

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    0cf4c39 View commit details
    Browse the repository at this point in the history

  5. Add .joins(:cards) to Player#cards to ensure all Card information is … 

    …available for testing/display

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    499ceda View commit details
    Browse the repository at this point in the history

  6. Add default value false to GameCards discarded and trashed attributes… 

    … in migration and schema

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    3b2051b View commit details
    Browse the repository at this point in the history

  7. Add Player State route from /games/id/players/id to PlayersController… 

    …#show

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    897f5ba View commit details
    Browse the repository at this point in the history

  8. Add initial PlayersController with #show, calling on player #deck and… 

    … #discard methods to serialize Player State

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    f67bd79 View commit details
    Browse the repository at this point in the history

  9. Fix Player State request spec to access JSON keys correctly using str… 

    …ings

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
Co-Authored-By: Chris Davis <davisc1014@gmail.com>
    @Patrick-Duvall @DavisC0801
    3 people committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    32f968d View commit details
    Browse the repository at this point in the history

  10. Add specs for Player #deck and #discard instance methods 

    Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    1b83990 View commit details
    Browse the repository at this point in the history

  11. Add Player #deck and #discard, determining which GameCards a player p… 

    …osseses are discarded or not

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    04b8f0d View commit details
    Browse the repository at this point in the history

  12. Add additonal key checks on GameCards for Player State endpoint spec 

    Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    ab1c8ff View commit details
    Browse the repository at this point in the history

  13. Change Spending Power attribute on Card factory to nil from 0 to foll… 

    …ow convention of Card attributes with no value

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    d0063fd View commit details
    Browse the repository at this point in the history

  14. Fix spec for Game State endpoint from spendingPower => nil from 0 to … 

    …follow convention

Co-Authored-By: Patrick Duvall <duvallp208@gmail.com>
    @Patrick-Duvall
    Brennan Ayers and Patrick-Duvall committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    0ddeb6c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Move Player serialization from PlayersController to PlayerSerializer

    Brennan Ayers committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    1d25d25 View commit details
    Browse the repository at this point in the history