Skip to content

Commit

Permalink
Merge pull request #558 from BrentOzarULTD/dev
Browse files Browse the repository at this point in the history 
Milestone 2016-10-22 - Release Two: The Releasening
  • Loading branch information
@BrentOzar
BrentOzar committed Oct 22, 2016
2 parents cae12a6 + 9eae691 commit 3604be0
Show file tree
Hide file tree
Showing 4 changed files with 672 additions and 97 deletions.
8 changes: 4 additions & 4 deletions sp_Blitz.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ALTER PROCEDURE [dbo].[sp_Blitz]
AS
SET NOCOUNT ON;
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
SET @VersionDate = '20161014';
SET @VersionDate = '20161022';
SET @OutputType = UPPER(@OutputType);

IF @Help = 1 PRINT '
Expand Down Expand Up @@ -469,7 +469,7 @@ AS
FROM sys.fn_trace_getinfo(1)
WHERE traceid=1 AND property=2;

SELECT @MsSinceWaitsCleared = DATEDIFF(MINUTE, create_date, CURRENT_TIMESTAMP) * 60000
SELECT @MsSinceWaitsCleared = DATEDIFF(MINUTE, create_date, CURRENT_TIMESTAMP) * 60000.0
FROM sys.databases
WHERE name='tempdb';

Expand Down Expand Up @@ -2594,9 +2594,9 @@ AS
'Performance' AS FindingGroup ,
'Poison Wait Detected: Serializable Locking' AS Finding ,
'http://BrentOzar.com/go/serializable' AS URL ,
CONVERT(VARCHAR(10), (SUM([wait_time_ms]) / 1000) / 86400) + ':' + CONVERT(VARCHAR(20), DATEADD(s, (SUM([wait_time_ms]) / 1000), 0), 108) + ' of LCK_R% waits have been recorded. This wait often indicates killer performance problems.'
CONVERT(VARCHAR(10), (SUM([wait_time_ms]) / 1000) / 86400) + ':' + CONVERT(VARCHAR(20), DATEADD(s, (SUM([wait_time_ms]) / 1000), 0), 108) + ' of LCK_M_R% waits have been recorded. This wait often indicates killer performance problems.'
FROM sys.[dm_os_wait_stats]
WHERE wait_type LIKE '%LCK%R%'
WHERE wait_type IN ('LCK_M_RS_S', 'LCK_M_RS_U', 'LCK_M_RIn_NL','LCK_M_RIn_S', 'LCK_M_RIn_U','LCK_M_RIn_X', 'LCK_M_RX_S', 'LCK_M_RX_U','LCK_M_RX_X')
HAVING SUM([wait_time_ms]) > (SELECT 5000 * datediff(HH,create_date,CURRENT_TIMESTAMP) AS hours_since_startup FROM sys.databases WHERE name='tempdb')
AND SUM([wait_time_ms]) > 60000
END
Expand Down
190 changes: 181 additions & 9 deletions sp_BlitzCache.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ CREATE TABLE ##bou_BlitzCacheProcs (
PercentWritesByType MONEY,
WritesPerMinute MONEY,
PlanCreationTime DATETIME,
PlanCreationTimeHours AS DATEDIFF(HOUR, PlanCreationTime, SYSDATETIME()),
LastExecutionTime DATETIME,
PlanHandle VARBINARY(64),
[Remove Plan Handle From Cache] AS
Expand Down Expand Up @@ -108,6 +109,8 @@ CREATE TABLE ##bou_BlitzCacheProcs (
is_forced_plan BIT,
is_forced_parameterized BIT,
is_cursor BIT,
is_optimistic_cursor BIT,
is_forward_only_cursor BIT,
is_parallel BIT,
is_forced_serial BIT,
is_key_lookup_expensive BIT,
Expand Down Expand Up @@ -139,6 +142,9 @@ CREATE TABLE ##bou_BlitzCacheProcs (
is_trivial BIT,
trace_flags_session VARCHAR(1000),
is_unused_grant BIT,
function_count INT,
clr_function_count INT,
is_table_variable BIT,
SetOptions VARCHAR(MAX),
Warnings VARCHAR(MAX)
);
Expand Down Expand Up @@ -166,6 +172,7 @@ ALTER PROCEDURE dbo.sp_BlitzCache
@OnlySqlHandles VARCHAR(MAX) = NULL ,
@QueryFilter VARCHAR(10) = 'ALL' ,
@DatabaseName NVARCHAR(128) = NULL ,
@StoredProcName NVARCHAR(128) = NULL,
@Reanalyze BIT = 0 ,
@SkipAnalysis BIT = 0 ,
@BringThePain BIT = 0 /* This will forcibly set @Top to 2,147,483,647 */
Expand Down Expand Up @@ -197,7 +204,7 @@ Unknown limitations of this version:
- May or may not be vulnerable to the wick effect.
Changes - for the full list of improvements and fixes in this version, see:
https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/milestone/4?closed=1
https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/
Expand Down Expand Up @@ -631,6 +638,7 @@ BEGIN
PercentWritesByType MONEY,
WritesPerMinute MONEY,
PlanCreationTime DATETIME,
PlanCreationTimeHours AS DATEDIFF(HOUR, PlanCreationTime, SYSDATETIME()),
LastExecutionTime DATETIME,
PlanHandle VARBINARY(64),
[Remove Plan Handle From Cache] AS
Expand Down Expand Up @@ -688,6 +696,8 @@ BEGIN
is_forced_plan BIT,
is_forced_parameterized BIT,
is_cursor BIT,
is_optimistic_cursor BIT,
is_forward_only_cursor BIT,
is_parallel BIT,
is_forced_serial BIT,
is_key_lookup_expensive BIT,
Expand Down Expand Up @@ -719,6 +729,9 @@ BEGIN
is_trivial BIT,
trace_flags_session VARCHAR(1000),
is_unused_grant BIT,
function_count INT,
clr_function_count INT,
is_table_variable BIT,
SetOptions VARCHAR(MAX),
Warnings VARCHAR(MAX)
);
Expand Down Expand Up @@ -834,6 +847,17 @@ CREATE TABLE #configuration (
value DECIMAL(38,0)
);

WITH x AS (
SELECT SUM(CASE WHEN DATEDIFF(HOUR, deqs.creation_time, SYSDATETIME()) < 24 THEN 1 ELSE 0 END) AS [plans_24],
SUM(CASE WHEN DATEDIFF(HOUR, deqs.creation_time, SYSDATETIME()) < 4 THEN 1 ELSE 0 END) AS [plans_4],
COUNT(deqs.creation_time) AS [total_plans]
FROM sys.dm_exec_query_stats AS deqs
)
SELECT CONVERT(DECIMAL(3,2), x.plans_24 / (1. * NULLIF(x.total_plans, 0))) * 100 AS [percent_24],
CONVERT(DECIMAL(3,2), x.plans_4 / (1. * NULLIF(x.total_plans, 0))) * 100 AS [percent_4],
@@SPID AS SPID
INTO #plan_creation
FROM x


SET @OnlySqlHandles = LTRIM(RTRIM(@OnlySqlHandles)) ;
Expand Down Expand Up @@ -875,6 +899,20 @@ BEGIN
END
END

IF @StoredProcName IS NOT NULL AND @StoredProcName <> N''

BEGIN

INSERT #only_sql_handles
( sql_handle )
SELECT ISNULL(deps.sql_handle, '')
FROM sys.dm_exec_procedure_stats AS deps
WHERE OBJECT_NAME(deps.object_id, deps.database_id) = @StoredProcName

END



IF ((@OnlyQueryHashes IS NOT NULL AND LEN(@OnlyQueryHashes) > 0)
OR (@IgnoreQueryHashes IS NOT NULL AND LEN(@IgnoreQueryHashes) > 0))
AND LEFT(@QueryFilter, 3) = 'pro'
Expand Down Expand Up @@ -1287,7 +1325,7 @@ BEGIN
t.t_TotalExecs,
t.t_TotalWrites,
qs.sql_handle AS SqlHandle,
NULL AS PlanHandle,
qs.plan_handle AS PlanHandle,
qs.query_hash AS QueryHash,
qs.query_plan_hash AS QueryPlanHash,
qs.min_worker_time / 1000.0,
Expand Down Expand Up @@ -1626,6 +1664,16 @@ FROM ##bou_BlitzCacheProcs p
CROSS APPLY p.QueryPlan.nodes('//p:StmtSimple') AS q(n)
OPTION (RECOMPILE) ;

WITH XMLNAMESPACES('http://schemas.microsoft.com/sqlserver/2004/07/showplan' AS p)
INSERT #statements
SELECT QueryHash ,
SqlHandle ,
PlanHandle,
q.n.query('.') AS statement
FROM ##bou_BlitzCacheProcs p
CROSS APPLY p.QueryPlan.nodes('//p:StmtCursor') AS q(n)
OPTION (RECOMPILE) ;

WITH XMLNAMESPACES('http://schemas.microsoft.com/sqlserver/2004/07/showplan' AS p)
SELECT QueryHash ,
SqlHandle ,
Expand Down Expand Up @@ -1735,18 +1783,35 @@ WITH XMLNAMESPACES('http://schemas.microsoft.com/sqlserver/2004/07/showplan' AS
UPDATE p
SET busy_loops = CASE WHEN (x.estimated_executions / 100.0) > x.estimated_rows THEN 1 END ,
tvf_join = CASE WHEN x.tvf_join = 1 THEN 1 END ,
warning_no_join_predicate = CASE WHEN x.no_join_warning = 1 THEN 1 END
warning_no_join_predicate = CASE WHEN x.no_join_warning = 1 THEN 1 END,
p.is_table_variable = CASE WHEN x.is_table_variable = 1 THEN 1 END
FROM ##bou_BlitzCacheProcs p
JOIN (
SELECT qs.SqlHandle,
relop.value('sum(/p:RelOp/@EstimateRows)', 'float') AS estimated_rows ,
relop.value('sum(/p:RelOp/@EstimateRewinds)', 'float') + relop.value('sum(/p:RelOp/@EstimateRebinds)', 'float') + 1.0 AS estimated_executions ,
relop.exist('/p:RelOp[contains(@LogicalOp, "Join")]/*/p:RelOp[(@LogicalOp[.="Table-valued function"])]') AS tvf_join,
relop.exist('/p:RelOp/p:Warnings[(@NoJoinPredicate[.="1"])]') AS no_join_warning
relop.exist('/p:RelOp/p:Warnings[(@NoJoinPredicate[.="1"])]') AS no_join_warning,
relop.exist('/p:RelOp//*[local-name() = "Object"]/@Table[contains(., "@")]') AS is_table_variable
FROM #relop qs
) AS x ON p.SqlHandle = x.SqlHandle
OPTION (RECOMPILE);

WITH XMLNAMESPACES('http://schemas.microsoft.com/sqlserver/2004/07/showplan' AS p)
, x AS (
SELECT qs.QueryHash,
n.fn.value('count(distinct-values(//p:UserDefinedFunction[not(@IsClrFunction)]))', 'INT') AS function_count,
n.fn.value('count(distinct-values(//p:UserDefinedFunction[@IsClrFunction = "1"]))', 'INT') AS clr_function_count
FROM #relop qs
CROSS APPLY relop.nodes('/p:RelOp/p:ComputeScalar/p:DefinedValues/p:DefinedValue/p:ScalarOperator') n(fn)
)
UPDATE p
SET p.function_count = x.function_count,
p.clr_function_count = x.clr_function_count
FROM ##bou_BlitzCacheProcs AS p
JOIN x ON x.QueryHash = p.QueryHash
OPTION (RECOMPILE);


WITH XMLNAMESPACES('http://schemas.microsoft.com/sqlserver/2004/07/showplan' AS p)
UPDATE ##bou_BlitzCacheProcs
Expand Down Expand Up @@ -1775,6 +1840,18 @@ WHERE [relop].exist('/p:RelOp[(@PhysicalOp[.="Remote Query"])]') = 1
WHERE ##bou_BlitzCacheProcs.SqlHandle = x.SqlHandle
OPTION (RECOMPILE) ;


WITH XMLNAMESPACES('http://schemas.microsoft.com/sqlserver/2004/07/showplan' AS p)
UPDATE b
SET b.is_optimistic_cursor = CASE WHEN n1.fn.exist('//p:CursorPlan/@CursorConcurrency[.="Optimistic"]') = 1 THEN 1 END,
b.is_forward_only_cursor = CASE WHEN n1.fn.exist('//p:CursorPlan/@ForwardOnly[.="true"]') = 1 THEN 1 ELSE 0 END
FROM ##bou_BlitzCacheProcs b
JOIN #statements AS qs
ON b.QueryHash = qs.QueryHash
CROSS APPLY qs.statement.nodes('/p:StmtCursor') AS n1(fn)
OPTION (RECOMPILE) ;


IF @v >= 12
BEGIN
RAISERROR('Checking for downlevel cardinality estimators being used on SQL Server 2014.', 0, 1) WITH NOWAIT;
Expand Down Expand Up @@ -2026,7 +2103,10 @@ SET Warnings = SUBSTRING(
CASE WHEN unparameterized_query = 1 THEN ', Unparameterized Query' ELSE '' END +
CASE WHEN missing_index_count > 0 THEN ', Missing Indexes (' + CAST(missing_index_count AS VARCHAR(3)) + ')' ELSE '' END +
CASE WHEN unmatched_index_count > 0 THEN ', Unmatched Indexes (' + CAST(unmatched_index_count AS VARCHAR(3)) + ')' ELSE '' END +
CASE WHEN is_cursor = 1 THEN ', Cursor' ELSE '' END +
CASE WHEN is_cursor = 1 THEN ', Cursor'
+ CASE WHEN is_optimistic_cursor = 1 THEN ' with optimistic' ELSE '' END
+ CASE WHEN is_forward_only_cursor = 0 THEN ' with forward only' ELSE '' END
ELSE '' END +
CASE WHEN is_parallel = 1 THEN ', Parallel' ELSE '' END +
CASE WHEN near_parallel = 1 THEN ', Nearly Parallel' ELSE '' END +
CASE WHEN frequent_execution = 1 THEN ', Frequent Execution' ELSE '' END +
Expand All @@ -2042,8 +2122,11 @@ SET Warnings = SUBSTRING(
CASE WHEN is_key_lookup_expensive = 1 THEN ', Expensive Key Lookup' ELSE '' END +
CASE WHEN is_remote_query_expensive = 1 THEN ', Expensive Remote Query' ELSE '' END +
CASE WHEN trace_flags_session IS NOT NULL THEN ', Session Level Trace Flag(s) Enabled: ' + trace_flags_session ELSE '' END +
CASE WHEN is_remote_query_expensive = 1 THEN ', Expensive Remote Query' ELSE '' END +
CASE WHEN is_unused_grant = 1 THEN ', Unused Memory Grant' ELSE '' END
CASE WHEN is_unused_grant = 1 THEN ', Unused Memory Grant' ELSE '' END +
CASE WHEN function_count > 0 THEN ', Calls ' + CONVERT(VARCHAR(10), function_count) + ' function(s)' ELSE '' END +
CASE WHEN clr_function_count > 0 THEN ', Calls ' + CONVERT(VARCHAR(10), clr_function_count) + ' CLR function(s)' ELSE '' END +
CASE WHEN PlanCreationTimeHours <= 4 THEN ', Plan created last 4hrs' ELSE '' END +
CASE WHEN is_table_variable = 1 THEN ', Table Variables' ELSE '' END
, 2, 200000)
OPTION (RECOMPILE) ;

Expand Down Expand Up @@ -2111,6 +2194,7 @@ BEGIN
PercentExecutionsByType money,' + N'
ExecutionsPerMinute money,
PlanCreationTime datetime,
PlanCreationTimeHours AS DATEDIFF(HOUR, PlanCreationTime, SYSDATETIME()),
LastExecutionTime datetime,
PlanHandle varbinary(64),
[Remove Plan Handle From Cache] AS
Expand Down Expand Up @@ -2352,7 +2436,11 @@ BEGIN
CASE WHEN is_key_lookup_expensive = 1 THEN '', 26'' ELSE '''' END +
CASE WHEN is_remote_query_expensive = 1 THEN '', 28'' ELSE '''' END +
CASE WHEN trace_flags_session IS NOT NULL THEN '', 29'' ELSE '''' END +
CASE WHEN is_unused_grant = 1 THEN '', 30'' ELSE '''' END
CASE WHEN is_unused_grant = 1 THEN '', 30'' ELSE '''' END +
CASE WHEN function_count > 0 IS NOT NULL THEN '', 31'' ELSE '''' END +
CASE WHEN clr_function_count > 0 THEN '', 32'' ELSE '''' END +
CASE WHEN PlanCreationTimeHours <= 4 THEN '', 33'' ELSE '''' END +
CASE WHEN is_table_variable = 1 then '', 34'' ELSE '''' END
, 2, 200000) AS opserver_warning , ' + @nl ;
END

Expand Down Expand Up @@ -2499,6 +2587,35 @@ BEGIN
'http://brentozar.com/blitzcache/cursors-found-slow-queries/',
'There are cursors in the plan cache. This is neither good nor bad, but it is a thing. Cursors are weird in SQL Server.');

IF EXISTS (SELECT 1/0
FROM ##bou_BlitzCacheProcs
WHERE is_cursor = 1
AND is_optimistic_cursor = 1
AND SPID = @@SPID)
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
VALUES (@@SPID,
4,
200,
'Cursors',
'Optimistic Cursors',
'http://brentozar.com/blitzcache/cursors-found-slow-queries/',
'There are optimistic cursors in the plan cache, which can harm performance.');

IF EXISTS (SELECT 1/0
FROM ##bou_BlitzCacheProcs
WHERE is_cursor = 1
AND is_forward_only_cursor = 0
AND SPID = @@SPID)
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
VALUES (@@SPID,
4,
200,
'Cursors',
'Non-forward Only Cursors',
'http://brentozar.com/blitzcache/cursors-found-slow-queries/',
'There are non-forward only cursors in the plan cache, which can harm performance.');


IF EXISTS (SELECT 1/0
FROM ##bou_BlitzCacheProcs
WHERE is_forced_parameterized = 1
Expand Down Expand Up @@ -2788,6 +2905,62 @@ BEGIN
'No URL yet.',
'Queries have large unused memory grants. This can cause concurrency issues, if queries are waiting a long time to get memory to run.') ;

IF EXISTS (SELECT 1/0
FROM ##bou_BlitzCacheProcs p
WHERE p.function_count > 0
AND SPID = @@SPID)
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
VALUES (@@SPID,
31,
100,
'Compute Scalar That References A Function',
'This could be trouble if you''re using Scalar Functions or MSTVFs',
'No URL yet.',
'Both of these will force queries to run serially, run at least once per row, and may result in poor cardinality estimates') ;

IF EXISTS (SELECT 1/0
FROM ##bou_BlitzCacheProcs p
WHERE p.clr_function_count > 0
AND SPID = @@SPID)
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
VALUES (@@SPID,
32,
100,
'Compute Scalar That References A CLR Function',
'This could be trouble if your CLR functions perform data access',
'No URL yet.',
'May force queries to run serially, run at least once per row, and may result in poor cardinlity estimates') ;


IF EXISTS (SELECT 1/0
FROM ##bou_BlitzCacheProcs p
WHERE p.is_table_variable = 1
AND SPID = @@SPID)
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
VALUES (@@SPID,
33,
100,
'Table Variables detected',
'Beware nasty side effects',
'No URL yet.',
'All modifications are single threaded, and selects have really low row estimates.') ;

IF EXISTS (SELECT 1/0
FROM #plan_creation p
WHERE p.percent_24 > 0
OR p.percent_4 > 0
AND SPID = @@SPID)
INSERT INTO ##bou_BlitzCacheResults (SPID, CheckID, Priority, FindingsGroup, Finding, URL, Details)
SELECT SPID,
999,
254,
'Plan Cache Information',
'You have ' + CONVERT(NVARCHAR(10), p.percent_24) + '% plans created in the past 24 hours, and ' + CONVERT(NVARCHAR(10), p.percent_4) + '% created in the past 4 hours.',
'No URL yet.',
'If these percentages are high, it may be a sign of memory pressure or plan cache instability.'
FROM #plan_creation p ;


IF EXISTS (SELECT 1/0
FROM #trace_flags AS tf
WHERE tf.global_trace_flags IS NOT NULL
Expand All @@ -2800,7 +2973,6 @@ BEGIN
'You have Global Trace Flags enabled on your server',
'https://www.brentozar.com/blitz/trace-flags-enabled-globally/',
'You have the following Global Trace Flags enabled: ' + (SELECT TOP 1 tf.global_trace_flags FROM #trace_flags AS tf WHERE tf.global_trace_flags IS NOT NULL)) ;


END

Expand Down
Loading

0 comments on commit 3604be0

Please sign in to comment.