Fixes for OneWire actuator and sensor (DS2413) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pioMask() function was not returning correct value as was incrementing after returning. Changed to increment before returning. OneWireActuator sense() function was not applying invert option correctly. This has been tested but there is a current issue with the multiple inheritance of the "OneWireActuator" class for both "Actuator" and SwitchSensor". If the order of these 2 are switched the sensor functionality via DS2413 works correctly but actuators via DS2413 no longer work. I have not been able to resolve this issue so for now door sensor does not work via DS2413.
|
This was fixed together with multiple other DS2413 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pioMask() function was not returning correct value as was incrementing
after returning. Changed to increment before returning.
OneWireActuator sense() function was not applying invert option
correctly. This has been tested but there is a current issue with the
multiple inheritance of the "OneWireActuator" class for both "Actuator"
and SwitchSensor". If the order of these 2 are switched the sensor
functionality via DS2413 works correctly but actuators via DS2413 no
longer work. I have not been able to resolve this issue so for now door
sensor does not work via DS2413.