Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High DPI Display problems #434

Closed
jawsdaws opened this issue Oct 11, 2018 · 9 comments · Fixed by #502
Closed

High DPI Display problems #434

jawsdaws opened this issue Oct 11, 2018 · 9 comments · Fixed by #502
Assignees

Comments

@jawsdaws
Copy link
Contributor

brewtargethdpi
On my new HDPI (to me anyways) display there are some strange artifacts and general weirdness. I've worked on some fixes. They are at https://github.com/jawsdaws/brewtarget if anyone wants to take a look. There's more to do though before I have a merge ready.

@jawsdaws
Copy link
Contributor Author

There looks to be an easy fix. I'm going to do more testing over the weekend, and next week. You can assign this one to me if you like.

@jawsdaws
Copy link
Contributor Author

I have some code for quite a few fixes here, but I'm not done. I would like to get some help testing to make sure I'm on the right path. I only have Linux available to test on so Mac and Windows help is needed. Not sure the best way to get help on this though. Maybe just merge the changes and see if it breaks? I guess also if you see this and can help, checkout https://github.com/jawsdaws/brewtarget/tree/HiDPI

@DRiKE
Copy link

DRiKE commented Jan 31, 2019

FWIW, I've been struggling with 'strange fonts' in QT5 apps from quite some time, and I just found a fix(?) the other day. Setting the environment var QT_FONT_DPI=96 did the trick. You might have to fiddle with the exact value, and I am unsure how/which other parts of my system/config affect this though.

@jawsdaws
Copy link
Contributor Author

jawsdaws commented Feb 1, 2019

Thanks @DRiKE . I tried that, but it was unreliable. It appears to work for some display drivers, but not others. I may be wrong, but that seemed to be the only thing I changed when it stopped working on Ubuntu 18.04. I've some code to adjust some of the pixel values based on logicalDotsPerInch() and it seems to work and be more robust. I've just been distracted with other things lately. :-)

@dzsquared
Copy link

Just a note for anyone who comes across the high-DPI scaling issues on Windows - these are the properties changes to BrewTarget.exe that I've made to display the app
image

@Wyrmwood
Copy link

Wyrmwood commented Aug 12, 2020 via email

@dschwilk
Copy link

dschwilk commented Sep 14, 2020

I have this issue with current develop branch build on kubuntu 20.04. Setting the environment variable QT_FONT_DPI=96 on the brewtarget command line fixes.

@jawsdaws
Copy link
Contributor Author

I have this issue with current develop branch build on kubuntu 20.04. Setting the environment variable QT_FONT_DPI=96 on the brewtarget command line fixes.

This is a much better solution than the hackery I was working on.

@matty0ung
Copy link
Contributor

I have a fix that addresses this without having to set environment variables etc. Specifically it makes the icons and range sliders a sensible size.

@matty0ung matty0ung mentioned this issue Dec 7, 2020
@mattiasmaahl mattiasmaahl linked a pull request Dec 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants