added better test coverage and fixed broken notification tests

BrianBelhumeur · Jul 22, 2013 · 8c3cde2 · 8c3cde2
1 parent c119c04
commit 8c3cde2
Show file tree

Hide file tree

Showing 8 changed files with 867 additions and 562 deletions.
diff --git a/lib/jsonrpc.js b/lib/jsonrpc.js
@@ -173,6 +173,7 @@ module.exports = (function(){
 				},
 				sendResponse = function () {
 					var finalOutput;
+					var contentLength, code;
 
 					if ( responseList.length ) {
 						if ( ! isBatch ) {
@@ -187,10 +188,13 @@ module.exports = (function(){
 						}
 					}
 
-					res.writeHead( 200, 
+					contentLength = Buffer.byteLength( finalOutput || '');
+					code = contentLength ? 200 : 204;
+
+					res.writeHead( code,
 						{
 							'Content-Type': 'application/json',
-							'Content-Length': Buffer.byteLength( finalOutput || '' )
+							'Content-Length': contentLength
 						}
 					);
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "node-express-json-rpc2",
-	"version": "1.0.1",
+	"version": "1.0.2",
 	"description": "Route-based JSON-RPC middleware for Express",
 	"keywords": [
 		"json-rpc",

diff --git a/test/testServer/public/index.html b/test/testServer/public/index.html
@@ -1,10 +1,10 @@
 <!DOCTYPE html>
 <html>
 <head>
-	<script src="javascripts/jquery-1.7.2.min.js"></script>
-	<script type="text/javascript" src="javascripts/qunit.js"></script>
+	<script src="javascripts/jquery-1.10.2.min.js"></script>
+	<script type="text/javascript" src="javascripts/qunit-1.12.0.js"></script>
 	<script type="text/javascript" src="javascripts/unitTests.js"></script>
-	<link rel="stylesheet" href="stylesheets/qunit.css" type="text/css" media="screen" />
+	<link rel="stylesheet" href="stylesheets/qunit-1.12.0.css" type="text/css" media="screen" />
 </head>
 <body>
 	<h1 id="qunit-header">JSON-RPC 2 Node module tests</h1>

diff --git a/test/testServer/public/javascripts/jquery-1.10.2.min.js b/test/testServer/public/javascripts/jquery-1.10.2.min.js
diff --git a/test/testServer/public/javascripts/jquery-1.7.2.min.js b/test/testServer/public/javascripts/jquery-1.7.2.min.js