fix a typo in external-representations.md #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtfierro
requested changes
Aug 20, 2023
|
Either way works if I'm understanding correctly. ref:hasTimeseriesReference
should be a subProperty of ref:hasExternalReference
Best regards,
Xiaohan Fu
…On Sun, Aug 20, 2023 at 2:55 PM Gabe Fierro ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I think it should actually be ref:hasExternalReference, no?
—
Reply to this email directly, view it on GitHub
<#17 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADVJW23A5OTDYVSF23JUWH3XWKBT5ANCNFSM6AAAAAA3XQ3P4Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The prefix still needs to be fixed in your PR. Either property is fine
--
Dr. Gabe Fierro | https://home.gtf.fyi<https://home.gtf.fyi/>
Assistant Professor of Computer Science | Colorado School of Mines
Joint Appointment | National Renewable Energy Laboratory
________________________________
From: Xiaohan Fu ***@***.***>
Sent: Sunday, August 20, 2023 4:24:46 PM
To: BrickSchema/docs ***@***.***>
Cc: Gabe Fierro ***@***.***>; Comment ***@***.***>
Subject: [EXTERNAL] Re: [BrickSchema/docs] fix a typo in external-representations.md (PR #17)
CAUTION: This email originated from outside of the Colorado School of Mines organization. Do not click on links or open attachments unless you recognize the sender and know the content is safe.
Either way works if I'm understanding correctly. ref:hasTimeseriesReference
should be a subProperty of ref:hasExternalReference
Best regards,
Xiaohan Fu
On Sun, Aug 20, 2023 at 2:55 PM Gabe Fierro ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I think it should actually be ref:hasExternalReference, no?
—
Reply to this email directly, view it on GitHub
<#17 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADVJW23A5OTDYVSF23JUWH3XWKBT5ANCNFSM6AAAAAA3XQ3P4Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub<#17 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAANRCSFFAR4CZOQUPTI3VDXWKFC5ANCNFSM6AAAAAA3XQ3P4Y>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
oops. fixed the typo in the fix lol |
|
okay i notice the example query below is against ExternalReference with no subref propagation so I just made it externalReference |
gtfierro
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.