Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App strings reworked #34

Closed
wants to merge 1 commit into from
Closed

Conversation

comradekingu
Copy link
Contributor

No description provided.

Copy link
Owner

@BrightDV BrightDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Only a small request from my side.

"@freePracticeTwo": {},
"freePracticeThree": "Free Practice 3",
"freePracticeThree": "Final practice FP3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to keep it to Free Practice FP3

Suggested change
"freePracticeThree": "Final practice FP3",
"freePracticeThree": "Free Practice FP3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Prix' of the Grand Prix' entered confused me a bit too

we should just follow how F1 says it as Grands Prix entered

@BrightDV
Copy link
Owner

BrightDV commented Feb 19, 2023

I finally made a commit on my side with my suggestions and added you as a co-author (db40194).
Thanks for PR!

@BrightDV BrightDV closed this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants