MI 2305: Dialog component #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanisha-agarwal
force-pushed
the
MI_2273
branch
2 times, most recently
from
378f2fe
to
55088b5
Compare
tanisha-agarwal
force-pushed
the
MI_2305
branch
from
96428a1
to
f8df6dc
Compare
tanisha-agarwal
force-pushed
the
MI_2273
branch
from
0afee3f
to
dba7044
Compare
tanisha-agarwal
force-pushed
the
MI_2305
branch
from
c7c773e
to
ccba56b
Compare
avas27JTG
reviewed
Nov 10, 2022
src/components/Dialog/Dialog.d.ts
Outdated
| show?: boolean; | ||
|
|
||
| /** | ||
| * Callback function which is to be triggered onHide scenarios |
There was a problem hiding this comment.
Suggested change
| * Callback function which is to be triggered onHide scenarios | |
| * Callback function which is to be triggered for "onHide" scenarios |
src/components/Dialog/Dialog.d.ts
Outdated
| onSubmitHandler?: () => void; | ||
|
|
||
| /** | ||
| * 'true' for a backdrop that triggers an "onHide" when clicked. |
There was a problem hiding this comment.
Suggested change
| * 'true' for a backdrop that triggers an "onHide" when clicked. | |
| * 'true' for a backdrop that triggers the "onHide" when clicked. |
| title: undefined, | ||
| children: <div> | ||
| <h1>{'Custom Jsx'}</h1> | ||
| <hr/> |
There was a problem hiding this comment.
prevent using <hr/>, BR it's deprecated now
avas27JTG
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
MI-2305
Description
Created Dialog Component
Screenshots
Dialog with just title
Dialog with title, description and primary action
Dialog with destructive primary action
Dialog with title and custom JSX as content
Dialog with just custom JSX as content
